Merge remote-tracking branch 'DotNetAnalyzers/master' into testing-library

Author: sharwell

NuGet.config

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <packageSources>
     <add key="roslyn" value="https://dotnet.myget.org/F/roslyn/api/v3/index.json" />

StyleCop.Analyzers/Directory.Build.props

@@ -8,8 +8,8 @@
     <Copyright>Copyright © Tunnel Vision Laboratories, LLC 2015</Copyright>
     <NeutralLanguage>en-US</NeutralLanguage>
 
-    <Version>1.1.0.39</Version>
-    <FileVersion>1.1.0.39</FileVersion>
+    <Version>1.1.0.40</Version>
+    <FileVersion>1.1.0.40</FileVersion>
     <InformationalVersion>1.1.0-dev</InformationalVersion>
   </PropertyGroup>
 
@@ -42,7 +42,7 @@
 
   <ItemGroup>
     <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="all" />
-    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta008" PrivateAssets="all" />
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.0-beta009" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1629UnitTests.cs

@@ -433,6 +433,49 @@ public interface ITest
             await VerifyCSharpFixAsync(testCode, expected, fixedTestCode, CancellationToken.None).ConfigureAwait(false);
         }
 
+        [Theory]
+        [WorkItem(2744, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2744")]
+        [InlineData("Summary. (For example.)")]
+        [InlineData("Summary (for example).")]
+        public async Task TestSentenceEndingWithParenthesesAsync(string allowedSummary)
+        {
+            var testCode = $@"
+/// <summary>
+/// {allowedSummary}
+/// </summary>
+public interface ITest
+{{
+}}
+";
+
+            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Fact]
+        [WorkItem(2744, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2744")]
+        public async Task TestSentenceEndingWithParenthesesWithoutPeriodAsync()
+        {
+            var testCode = @"
+/// <summary>
+/// Summary (for example)
+/// </summary>
+public interface ITest
+{
+}
+";
+            var fixedTestCode = $@"
+/// <summary>
+/// Summary (for example).
+/// </summary>
+public interface ITest
+{{
+}}
+";
+
+            DiagnosticResult expected = Diagnostic().WithLocation(3, 26);
+            await VerifyCSharpFixAsync(testCode, expected, fixedTestCode, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         public async Task TestMultipleParagraphBlocksAsync()
         {

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1629DocumentationTextMustEndWithAPeriod.cs

@@ -91,7 +91,8 @@ protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext co
                 var textWithoutTrailingWhitespace = node.Value.TrimEnd(' ', '\r', '\n');
                 if (!string.IsNullOrEmpty(textWithoutTrailingWhitespace))
                 {
-                    if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal))
+                    if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal)
+                        && !textWithoutTrailingWhitespace.EndsWith(".)", StringComparison.Ordinal))
                     {
                         context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations[0], NoCodeFixProperties));
 
@@ -123,6 +124,7 @@ private static void HandleSectionOrBlockXmlElement(SyntaxNodeAnalysisContext con
                         if (!string.IsNullOrEmpty(textWithoutTrailingWhitespace))
                         {
                             if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal)
+                                && !textWithoutTrailingWhitespace.EndsWith(".)", StringComparison.Ordinal)
                                 && (startingWithFinalParagraph || !textWithoutTrailingWhitespace.EndsWith(":", StringComparison.Ordinal))
                                 && !textWithoutTrailingWhitespace.EndsWith("-or-", StringComparison.Ordinal))
                             {