Skip to content

Commit 65d8711

Browse files
authored
Merge pull request #2805 from sharwell/status-updates
Status page updates
2 parents 96b59fc + c205950 commit 65d8711

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

StyleCop.Analyzers/StyleCop.Analyzers.Status.Generator/SolutionReader.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -314,18 +314,17 @@ private IEnumerable<DiagnosticDescriptor> GetDescriptor(INamedTypeSymbol classSy
314314
var codeFixes = this.CodeFixProviders
315315
.Where(x => x.FixableDiagnosticIds.Contains(diagnosticId))
316316
.Select(x => this.IsBatchFixer(x))
317-
.Where(x => x != null)
318-
.Select(x => (bool)x).ToArray();
317+
.ToArray();
319318

320319
hasCodeFix = codeFixes.Length > 0;
321320

322321
codeFixStatus = hasCodeFix ? CodeFixStatus.Implemented : CodeFixStatus.NotYetImplemented;
323322

324-
if (codeFixes.Any(x => x))
323+
if (codeFixes.Any(x => x ?? false))
325324
{
326325
fixAllStatus = FixAllStatus.BatchFixer;
327326
}
328-
else if (codeFixes.Length > 0)
327+
else if (codeFixes.Any(x => x != null))
329328
{
330329
fixAllStatus = FixAllStatus.CustomImplementation;
331330
}

docs/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,8 @@ <h2>This page is reporting the current status of <a href="https://github.com/Dot
122122
<td style="overflow: visible; width: 0;">
123123
{{if CodeFixStatus === "Implemented"}}
124124
<i class="fa fa-check" style="color: green;"></i>
125-
{{else CodeFixStatus === NotImplemented}}
126-
<i class="fa fa-times" style="color: red;"></i>
125+
{{else CodeFixStatus === "NotImplemented"}}
126+
<i class="fa fa-times" style="color: red;" title="{{>NoCodeFixReason}}"></i>
127127
{{else}}
128128
<i class="fa fa-exclamation" style="color: blue;"></i>
129129
{{/if}}

0 commit comments

Comments
 (0)