Improved behavior with invalid included documentation

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1629UnitTests.cs

@@ -284,7 +284,18 @@ public int TestMethod<T>(T arg1)
             Assert.Empty(offeredFixes);
         }
 
-        //// TODO: Verify <inheritdoc/> together with additional elements
+        [Fact]
+        public async Task TestInvalidIncludedDocumentationAsync()
+        {
+            var testCode = @"
+/// <include file='InvalidClassInheritDoc.xml' path='/TestClass/*'/>
+public class TestClass
+{
+}
+";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
 
         protected override Project ApplyCompilationOptions(Project project)
         {
@@ -297,6 +308,13 @@ protected override Project ApplyCompilationOptions(Project project)
 ";
             resolver.XmlReferences.Add("ClassInheritDoc.xml", contentClassInheritDoc);
 
+            string contentInvalidClassInheritDoc = @"<?xml version=""1.0"" encoding=""utf-8"" ?>
+<TestClass>
+  <summary>Test class<summary>
+</TestClass>
+";
+            resolver.XmlReferences.Add("InvalidClassInheritDoc.xml", contentInvalidClassInheritDoc);
+
             string contentPropertyInheritDoc = @"<?xml version=""1.0"" encoding=""utf-8"" ?>
 <TestClass>
   <TestProperty>

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1629DocumentationTextMustEndWithAPeriod.cs

@@ -107,26 +107,20 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
         /// <inheritdoc/>
         protected override void HandleCompleteDocumentation(SyntaxNodeAnalysisContext context, bool needsComment, XElement completeDocumentation, params Location[] diagnosticLocations)
         {
-            try
+            foreach (var node in completeDocumentation.Nodes().OfType<XElement>())
             {
-                foreach (var node in completeDocumentation.Nodes().Cast<XElement>())
+                var textWithoutTrailingWhitespace = node.Value.TrimEnd(' ', '\r', '\n');
+                if (!string.IsNullOrEmpty(textWithoutTrailingWhitespace))
                 {
-                    var textWithoutTrailingWhitespace = node.Value.TrimEnd(' ', '\r', '\n');
-                    if (!string.IsNullOrEmpty(textWithoutTrailingWhitespace))
+                    if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal))
                     {
-                        if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal))
-                        {
-                            context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations[0], NoCodeFixProperties));
+                        context.ReportDiagnostic(Diagnostic.Create(Descriptor, diagnosticLocations[0], NoCodeFixProperties));
 
-                            // only report a single instance of the diagnostic, as they will all be reported on the same location anyway.
-                            break;
-                        }
+                        // only report a single instance of the diagnostic, as they will all be reported on the same location anyway.
+                        break;
                     }
                 }
             }
-            catch (InvalidCastException)
-            {
-            }
         }
     }
 }