Skip to content

Commit 6683e23

Browse files
committed
Fix RS1033 (Define diagnostic description correctly)
1 parent 63b6e89 commit 6683e23

6 files changed

Lines changed: 11 additions & 9 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers.Test/Helpers/ExclusionTestAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ internal class ExclusionTestAnalyzer : DiagnosticAnalyzer
2020
internal const string DiagnosticId = "SA9999";
2121
private const string Title = "Exclusion test";
2222
private const string MessageFormat = "Exclusion test";
23-
private const string Description = "Exclusion test";
23+
private const string Description = "Exclusion test.";
2424
private const string HelpLink = "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA9999.md";
2525

2626
private static readonly DiagnosticDescriptor Descriptor =

StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/LayoutResources.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/LayoutResources.resx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,13 @@
361361
<value>Fix whitespace at the end of the file</value>
362362
</data>
363363
<data name="SA1518DescriptionAllow" xml:space="preserve">
364-
<value>Code should not contain blank lines at the end of the file</value>
364+
<value>Code should not contain blank lines at the end of the file.</value>
365365
</data>
366366
<data name="SA1518DescriptionOmit" xml:space="preserve">
367-
<value>File may not end with a newline character</value>
367+
<value>File may not end with a newline character.</value>
368368
</data>
369369
<data name="SA1518DescriptionRequire" xml:space="preserve">
370-
<value>File is required to end with a single newline character</value>
370+
<value>File is required to end with a single newline character.</value>
371371
</data>
372372
<data name="SA1518MessageFormatAllow" xml:space="preserve">
373373
<value>Code should not contain blank lines at the end of the file</value>

StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/MaintainabilityResources.Designer.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/MaintainabilityResources.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@
256256
<value>Change encoding from '{0}' to UTF-8 with byte order mark</value>
257257
</data>
258258
<data name="SA1412Description" xml:space="preserve">
259-
<value>Source files should be saved using the UTF-8 encoding with a byte order mark</value>
259+
<value>Source files should be saved using the UTF-8 encoding with a byte order mark.</value>
260260
</data>
261261
<data name="SA1412MessageFormat" xml:space="preserve">
262262
<value>Store files as UTF-8 with byte order mark</value>

StyleCop.Analyzers/StyleCop.Analyzers/SpecialRules/SA0002InvalidSettingsFile.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ internal class SA0002InvalidSettingsFile : DiagnosticAnalyzer
2727
private static readonly LocalizableString Description = new LocalizableResourceString(nameof(SpecialResources.SA0002Description), SpecialResources.ResourceManager, typeof(SpecialResources));
2828

2929
private static readonly DiagnosticDescriptor Descriptor =
30+
#pragma warning disable RS1033 // Define diagnostic description correctly (Description ends with formatted exception text)
3031
new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.SpecialRules, DiagnosticSeverity.Warning, AnalyzerConstants.EnabledByDefault, Description, HelpLink);
32+
#pragma warning restore RS1033 // Define diagnostic description correctly
3133

3234
private static readonly Action<CompilationAnalysisContext> CompilationAction = HandleCompilation;
3335

0 commit comments

Comments
 (0)