Fix SA1212 hard-coding of CRLF

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/SA1212SA1213CodeFixProvider.cs

@@ -53,6 +53,8 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
         private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)
         {
             var syntaxRoot = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
+            var sourceText = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);
+            var options = document.Project.Solution.Workspace.Options;
 
             var accessorToken = syntaxRoot.FindToken(diagnostic.Location.SourceSpan.Start);
             var accessorList = (AccessorListSyntax)accessorToken.Parent.Parent;
@@ -67,8 +69,9 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
 
             if (HasLeadingBlankLines(secondAccessor))
             {
+                var endOfLine = FormattingHelper.GetEndOfLineForCodeFix(firstAccesor.Keyword, sourceText, options);
                 trackedFirstAccessor = syntaxRoot.GetCurrentNode(firstAccesor);
-                var newFirstAccessor = trackedFirstAccessor.WithLeadingTrivia(new[] { SyntaxFactory.CarriageReturnLineFeed }.Concat(firstAccesor.GetFirstToken().WithoutLeadingBlankLines().LeadingTrivia));
+                var newFirstAccessor = trackedFirstAccessor.WithLeadingTrivia(new[] { endOfLine }.Concat(firstAccesor.GetFirstToken().WithoutLeadingBlankLines().LeadingTrivia));
                 syntaxRoot = syntaxRoot.ReplaceNode(trackedFirstAccessor, newFirstAccessor);
             }
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/OrderingRules/SA1212UnitTests.cs

@@ -1,22 +1,23 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.OrderingRules
 {
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis.Testing;
+    using StyleCop.Analyzers.Test.Helpers;
     using Xunit;
     using static StyleCop.Analyzers.Test.Verifiers.StyleCopCodeFixVerifier<
         StyleCop.Analyzers.OrderingRules.SA1212PropertyAccessorsMustFollowOrder,
         StyleCop.Analyzers.OrderingRules.SA1212SA1213CodeFixProvider>;
 
     public class SA1212UnitTests
     {
-        [Fact]
-        public async Task TestPropertyWithDocumentationAsync()
+        [Theory]
+        [InlineData("\n")]
+        [InlineData("\r\n")]
+        public async Task TestPropertyWithDocumentationAsync(string lineEnding)
         {
             var testCode = @"
 public class Foo
@@ -28,10 +29,10 @@ public int Prop
         /// <summary>
         /// The setter documentation
         /// </summary>
-        set
+        {|#0:set
         {
             i = value;
-        }
+        }|}
 
         /// <summary>
         /// The getter documentation
@@ -41,9 +42,9 @@ public int Prop
             return i;
         }
     }
-}";
+}".ReplaceLineEndings(lineEnding);
 
-            DiagnosticResult expected = Diagnostic().WithLocation(11, 9);
+            DiagnosticResult expected = Diagnostic().WithLocation(0);
 
             var fixedCode = @"
 public class Foo
@@ -68,7 +69,7 @@ public int Prop
             i = value;
         }
     }
-}";
+}".ReplaceLineEndings(lineEnding);
 
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }