Code review update: Split SA1402SettingsConfiguration.cs in two files.

Author: bjornhellander

StyleCop.Analyzers/StyleCop.Analyzers.Test/MaintainabilityRules/SA1402SettingsConfiguration.cs

@@ -3,10 +3,6 @@
 
 namespace StyleCop.Analyzers.Test.MaintainabilityRules
 {
-    using System.Collections.Generic;
-    using System.Diagnostics.CodeAnalysis;
-    using System.Linq;
-
     public enum SA1402SettingsConfiguration
     {
         /// <summary>
@@ -24,35 +20,4 @@ public enum SA1402SettingsConfiguration
         /// </summary>
         ConfigureAsNonTopLevelType,
     }
-
-    [SuppressMessage("StyleCop.CSharp.MaintainabilityRules", "SA1649:File name must match first type name.", Justification = "Extension method for enum above.")]
-    public static class SA1402SettingsConfigurationExtensions
-    {
-        public static string GetSettings(this SA1402SettingsConfiguration configuration, string keyword)
-        {
-            if (configuration == SA1402SettingsConfiguration.KeepDefaultConfiguration)
-            {
-                return null;
-            }
-
-            var keywords = new List<string> { "class", "interface", "struct", "enum", "delegate" };
-            if (configuration == SA1402SettingsConfiguration.ConfigureAsNonTopLevelType)
-            {
-                keywords.Remove(keyword);
-            }
-
-            var keywordsStr = string.Join(", ", keywords.Select(x => "\"" + x + "\""));
-
-            var settings = $@"
-{{
-  ""settings"": {{
-    ""maintainabilityRules"": {{
-      ""topLevelTypes"": [{keywordsStr}]
-    }}
-  }}
-}}";
-
-            return settings;
-        }
-    }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test/MaintainabilityRules/SA1402SettingsConfigurationExtensions.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Test.MaintainabilityRules
+{
+    using System.Collections.Generic;
+    using System.Linq;
+
+    public static class SA1402SettingsConfigurationExtensions
+    {
+        public static string GetSettings(this SA1402SettingsConfiguration configuration, string keyword)
+        {
+            if (configuration == SA1402SettingsConfiguration.KeepDefaultConfiguration)
+            {
+                return null;
+            }
+
+            var keywords = new List<string> { "class", "interface", "struct", "enum", "delegate" };
+            if (configuration == SA1402SettingsConfiguration.ConfigureAsNonTopLevelType)
+            {
+                keywords.Remove(keyword);
+            }
+
+            var keywordsStr = string.Join(", ", keywords.Select(x => "\"" + x + "\""));
+
+            var settings = $@"
+{{
+  ""settings"": {{
+    ""maintainabilityRules"": {{
+      ""topLevelTypes"": [{keywordsStr}]
+    }}
+  }}
+}}";
+
+            return settings;
+        }
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers.Test/StyleCop.Analyzers.Test.csproj

@@ -251,6 +251,7 @@
     <Compile Include="MaintainabilityRules\SA1402ForClassUnitTests.cs" />
     <Compile Include="MaintainabilityRules\SA1402ForBlockDeclarationUnitTestsBase.cs" />
     <Compile Include="MaintainabilityRules\SA1402SettingsConfiguration.cs" />
+    <Compile Include="MaintainabilityRules\SA1402SettingsConfigurationExtensions.cs" />
     <Compile Include="MaintainabilityRules\SA1403UnitTests.cs" />
     <Compile Include="MaintainabilityRules\SA1404UnitTests.cs" />
     <Compile Include="MaintainabilityRules\SA1405UnitTests.cs" />