Make fields readonly

sharwell · sharwell · commit 6f50491ff143 · 2018-05-07T07:04:07.000-05:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.TreeTextSpan.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.TreeTextSpan.cs
@@ -157,9 +157,9 @@ internal TreeTextSpan GetContainingSpan(TextSpan textSpan)
             /// </summary>
             internal class Builder
             {
+                private readonly List<Builder> children = new List<Builder>();
                 private int start;
                 private int end = int.MaxValue;
-                private List<Builder> children = new List<Builder>();
 
                 /// <summary>
                 /// Initializes a new instance of the <see cref="Builder"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.UsingsSorter.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.UsingsSorter.cs
@@ -30,12 +30,12 @@ private class UsingsSorter
             private readonly bool separateSystemDirectives;
             private readonly bool insertBlankLinesBetweenGroups;
 
-            private SourceMap sourceMap;
+            private readonly SourceMap sourceMap;
 
-            private Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> systemUsings = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
-            private Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> namespaceUsings = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
-            private Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> aliases = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
-            private Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> staticImports = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
+            private readonly Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> systemUsings = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
+            private readonly Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> namespaceUsings = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
+            private readonly Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> aliases = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
+            private readonly Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>> staticImports = new Dictionary<TreeTextSpan, List<UsingDirectiveSyntax>>();
 
             public UsingsSorter(StyleCopSettings settings, SemanticModel semanticModel, CompilationUnitSyntax compilationUnit, ImmutableArray<SyntaxTrivia> fileHeader)
             {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.cs
@@ -422,7 +422,7 @@ private class UsingSyntaxRewriter : CSharpSyntaxRewriter
             private readonly List<UsingDirectiveSyntax> stripList;
             private readonly Dictionary<UsingDirectiveSyntax, UsingDirectiveSyntax> replaceMap;
             private readonly ImmutableArray<SyntaxTrivia> fileHeader;
-            private LinkedList<SyntaxToken> tokensToStrip = new LinkedList<SyntaxToken>();
+            private readonly LinkedList<SyntaxToken> tokensToStrip = new LinkedList<SyntaxToken>();
 
             public UsingSyntaxRewriter(List<UsingDirectiveSyntax> stripList, Dictionary<UsingDirectiveSyntax, UsingDirectiveSyntax> replaceMap, ImmutableArray<SyntaxTrivia> fileHeader)
             {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1101UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1101UnitTests.cs
@@ -130,7 +130,7 @@ public void InstanceMethodName(int ParameterName)
         }
         ";
 
-        private static string fixedCode = @"
+        private static readonly string FixedCode = @"
         using System;
         public class BaseTypeName
         {
@@ -303,7 +303,7 @@ public void ConvertAll<T>(T value) { }
         [Fact]
         public async Task TestPrefixLocalCallsWithThisCodeFixAsync()
         {
-            await this.VerifyCSharpFixAsync(ReferenceCode, fixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpFixAsync(ReferenceCode, FixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);
         }
 
         /// <summary>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/Settings/SettingsUnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/Settings/SettingsUnitTests.cs
@@ -375,7 +375,7 @@ private static async Task<SyntaxTreeAnalysisContext> CreateAnalysisContextAsync(
 
         private class AdditionalTextHelper : AdditionalText
         {
-            private SourceText sourceText;
+            private readonly SourceText sourceText;
 
             public AdditionalTextHelper(string path, string text)
             {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonArray.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonArray.cs
@@ -15,7 +15,7 @@ namespace LightJson
     [DebuggerTypeProxy(typeof(JsonArrayDebugView))]
     internal sealed class JsonArray : IEnumerable<JsonValue>
     {
-        private IList<JsonValue> items;
+        private readonly IList<JsonValue> items;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="JsonArray"/> class.
@@ -167,7 +167,7 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()
         [ExcludeFromCodeCoverage]
         private class JsonArrayDebugView
         {
-            private JsonArray jsonArray;
+            private readonly JsonArray jsonArray;
 
             public JsonArrayDebugView(JsonArray jsonArray)
             {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonObject.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonObject.cs
@@ -14,7 +14,7 @@ namespace LightJson
     [DebuggerTypeProxy(typeof(JsonObjectDebugView))]
     internal sealed class JsonObject : IEnumerable<KeyValuePair<string, JsonValue>>, IEnumerable<JsonValue>
     {
-        private IDictionary<string, JsonValue> properties;
+        private readonly IDictionary<string, JsonValue> properties;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="JsonObject"/> class.
@@ -189,7 +189,7 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()
         [ExcludeFromCodeCoverage]
         private class JsonObjectDebugView
         {
-            private JsonObject jsonObject;
+            private readonly JsonObject jsonObject;
 
             public JsonObjectDebugView(JsonObject jsonObject)
             {
@@ -218,10 +218,10 @@ public KeyValuePair[] Keys
             public class KeyValuePair
             {
                 [DebuggerBrowsable(DebuggerBrowsableState.Never)]
-                private string key;
+                private readonly string key;
 
                 [DebuggerBrowsable(DebuggerBrowsableState.Never)]
-                private JsonValue value;
+                private readonly JsonValue value;
 
                 public KeyValuePair(string key, JsonValue value)
                 {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonValue.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonValue.cs
@@ -839,7 +839,7 @@ public override int GetHashCode()
         [ExcludeFromCodeCoverage]
         private class JsonValueDebugView
         {
-            private JsonValue jsonValue;
+            private readonly JsonValue jsonValue;
 
             public JsonValueDebugView(JsonValue jsonValue)
             {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/Serialization/JsonReader.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/Serialization/JsonReader.cs
@@ -14,7 +14,7 @@ namespace LightJson.Serialization
     /// </summary>
     internal sealed class JsonReader
     {
-        private TextScanner scanner;
+        private readonly TextScanner scanner;
 
         private JsonReader(TextReader reader)
         {
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/Serialization/TextScanner.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LightJson/Serialization/TextScanner.cs
@@ -11,7 +11,7 @@ namespace LightJson.Serialization
     /// </summary>
     internal sealed class TextScanner
     {
-        private TextReader reader;
+        private readonly TextReader reader;
         private TextPosition position;
 
         /// <summary>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/DocumentationSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/DocumentationSettings.cs
@@ -29,67 +29,67 @@ internal class DocumentationSettings
         /// <summary>
         /// This is the backing field for the <see cref="CompanyName"/> property.
         /// </summary>
-        private string companyName;
+        private readonly string companyName;
 
         /// <summary>
         /// This is the backing field for the <see cref="GetCopyrightText(string)"/> method.
         /// </summary>
-        private string copyrightText;
-
-        /// <summary>
-        /// This is the cache for the <see cref="GetCopyrightText(string)"/> method.
-        /// </summary>
-        private string copyrightTextCache;
+        private readonly string copyrightText;
 
         /// <summary>
         /// This is the backing field for the <see cref="HeaderDecoration"/> property.
         /// </summary>
-        private string headerDecoration;
+        private readonly string headerDecoration;
 
         /// <summary>
         /// This is the backing field for the <see cref="Variables"/> property.
         /// </summary>
-        private ImmutableDictionary<string, string>.Builder variables;
+        private readonly ImmutableDictionary<string, string>.Builder variables;
 
         /// <summary>
         /// This is the backing field for the <see cref="XmlHeader"/> property.
         /// </summary>
-        private bool xmlHeader;
+        private readonly bool xmlHeader;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentExposedElements"/> property.
         /// </summary>
-        private bool documentExposedElements;
+        private readonly bool documentExposedElements;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentInternalElements"/> property.
         /// </summary>
-        private bool documentInternalElements;
+        private readonly bool documentInternalElements;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentPrivateElements"/> property.
         /// </summary>
-        private bool documentPrivateElements;
+        private readonly bool documentPrivateElements;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentInterfaces"/> property.
         /// </summary>
-        private bool documentInterfaces;
+        private readonly bool documentInterfaces;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentPrivateFields"/> property.
         /// </summary>
-        private bool documentPrivateFields;
+        private readonly bool documentPrivateFields;
 
         /// <summary>
         /// This is the backing field for the <see cref="FileNamingConvention"/> property.
         /// </summary>
-        private FileNamingConvention fileNamingConvention;
+        private readonly FileNamingConvention fileNamingConvention;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentationCulture"/> property.
         /// </summary>
-        private string documentationCulture;
+        private readonly string documentationCulture;
+
+        /// <summary>
+        /// This is the cache for the <see cref="GetCopyrightText(string)"/> method.
+        /// </summary>
+        private string copyrightTextCache;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="DocumentationSettings"/> class during JSON deserialization.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/IndentationSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/IndentationSettings.cs
@@ -10,17 +10,17 @@ internal class IndentationSettings
         /// <summary>
         /// This is the backing field for the <see cref="IndentationSize"/> property.
         /// </summary>
-        private int indentationSize;
+        private readonly int indentationSize;
 
         /// <summary>
         /// This is the backing field for the <see cref="TabSize"/> property.
         /// </summary>
-        private int tabSize;
+        private readonly int tabSize;
 
         /// <summary>
         /// This is the backing field for the <see cref="UseTabs"/> property.
         /// </summary>
-        private bool useTabs;
+        private readonly bool useTabs;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="IndentationSettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/LayoutSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/LayoutSettings.cs
@@ -10,12 +10,12 @@ internal class LayoutSettings
         /// <summary>
         /// This is the backing field for the <see cref="NewlineAtEndOfFile"/> property.
         /// </summary>
-        private OptionSetting newlineAtEndOfFile;
+        private readonly OptionSetting newlineAtEndOfFile;
 
         /// <summary>
         /// This is the backing field for the <see cref="AllowConsecutiveUsings"/> property.
         /// </summary>
-        private bool allowConsecutiveUsings;
+        private readonly bool allowConsecutiveUsings;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="LayoutSettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/MaintainabilitySettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/MaintainabilitySettings.cs
@@ -17,7 +17,7 @@ internal class MaintainabilitySettings
         /// <summary>
         /// This is the backing field for the <see cref="TopLevelTypes"/> property.
         /// </summary>
-        private ImmutableArray<TopLevelType>.Builder topLevelTypes;
+        private readonly ImmutableArray<TopLevelType>.Builder topLevelTypes;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="MaintainabilitySettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/NamingSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/NamingSettings.cs
@@ -12,12 +12,12 @@ internal class NamingSettings
         /// <summary>
         /// This is the backing field for the <see cref="AllowCommonHungarianPrefixes"/> property.
         /// </summary>
-        private bool allowCommonHungarianPrefixes;
+        private readonly bool allowCommonHungarianPrefixes;
 
         /// <summary>
         /// This is the backing field for the <see cref="AllowedHungarianPrefixes"/> property.
         /// </summary>
-        private ImmutableArray<string>.Builder allowedHungarianPrefixes;
+        private readonly ImmutableArray<string>.Builder allowedHungarianPrefixes;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="NamingSettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/OrderingSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/OrderingSettings.cs
@@ -20,22 +20,22 @@ internal class OrderingSettings
         /// <summary>
         /// This is the backing field for the <see cref="ElementOrder"/> property.
         /// </summary>
-        private ImmutableArray<OrderingTrait>.Builder elementOrder;
+        private readonly ImmutableArray<OrderingTrait>.Builder elementOrder;
 
         /// <summary>
         /// This is the backing field for the <see cref="SystemUsingDirectivesFirst"/> property.
         /// </summary>
-        private bool systemUsingDirectivesFirst;
+        private readonly bool systemUsingDirectivesFirst;
 
         /// <summary>
         /// This is the backing field for the <see cref="UsingDirectivesPlacement"/> property.
         /// </summary>
-        private UsingDirectivesPlacement usingDirectivesPlacement;
+        private readonly UsingDirectivesPlacement usingDirectivesPlacement;
 
         /// <summary>
         /// This is the backing field for the <see cref="BlankLinesBetweenUsingGroups"/> property.
         /// </summary>
-        private OptionSetting blankLinesBetweenUsingGroups;
+        private readonly OptionSetting blankLinesBetweenUsingGroups;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="OrderingSettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/ReadabilitySettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/ReadabilitySettings.cs
@@ -10,7 +10,7 @@ internal class ReadabilitySettings
         /// <summary>
         /// This is the backing field for the <see cref="AllowBuiltInTypeAliases"/> property.
         /// </summary>
-        private bool allowBuiltInTypeAliases;
+        private readonly bool allowBuiltInTypeAliases;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ReadabilitySettings"/> class.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/StyleCopSettings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Settings/ObjectModel/StyleCopSettings.cs
@@ -10,42 +10,42 @@ internal class StyleCopSettings
         /// <summary>
         /// This is the backing field for the <see cref="Indentation"/> property.
         /// </summary>
-        private IndentationSettings indentation;
+        private readonly IndentationSettings indentation;
 
         /// <summary>
         /// This is the backing field for the <see cref="SpacingRules"/> property.
         /// </summary>
-        private SpacingSettings spacingRules;
+        private readonly SpacingSettings spacingRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="ReadabilityRules"/> property.
         /// </summary>
-        private ReadabilitySettings readabilityRules;
+        private readonly ReadabilitySettings readabilityRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="OrderingRules"/> property.
         /// </summary>
-        private OrderingSettings orderingRules;
+        private readonly OrderingSettings orderingRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="NamingRules"/> property.
         /// </summary>
-        private NamingSettings namingRules;
+        private readonly NamingSettings namingRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="MaintainabilityRules"/> property.
         /// </summary>
-        private MaintainabilitySettings maintainabilityRules;
+        private readonly MaintainabilitySettings maintainabilityRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="LayoutRules"/> property.
         /// </summary>
-        private LayoutSettings layoutRules;
+        private readonly LayoutSettings layoutRules;
 
         /// <summary>
         /// This is the backing field for the <see cref="DocumentationRules"/> property.
         /// </summary>
-        private DocumentationSettings documentationRules;
+        private readonly DocumentationSettings documentationRules;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="StyleCopSettings"/> class.

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ private class UsingSyntaxRewriter : CSharpSyntaxRewriter`
`422`	`422`	`private readonly List<UsingDirectiveSyntax> stripList;`
`423`	`423`	`private readonly Dictionary<UsingDirectiveSyntax, UsingDirectiveSyntax> replaceMap;`
`424`	`424`	`private readonly ImmutableArray<SyntaxTrivia> fileHeader;`
`425`		`- private LinkedList<SyntaxToken> tokensToStrip = new LinkedList<SyntaxToken>();`
	`425`	`+ private readonly LinkedList<SyntaxToken> tokensToStrip = new LinkedList<SyntaxToken>();`
`426`	`426`
`427`	`427`	`public UsingSyntaxRewriter(List<UsingDirectiveSyntax> stripList, Dictionary<UsingDirectiveSyntax, UsingDirectiveSyntax> replaceMap, ImmutableArray<SyntaxTrivia> fileHeader)`
`428`	`428`	`{`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ public void InstanceMethodName(int ParameterName)`
`130`	`130`	`}`
`131`	`131`	`";`
`132`	`132`
`133`		`- private static string fixedCode = @"`
	`133`	`+ private static readonly string FixedCode = @"`
`134`	`134`	`using System;`
`135`	`135`	`public class BaseTypeName`
`136`	`136`	`{`
`@@ -303,7 +303,7 @@ public void ConvertAll<T>(T value) { }`
`303`	`303`	`[Fact]`
`304`	`304`	`public async Task TestPrefixLocalCallsWithThisCodeFixAsync()`
`305`	`305`	`{`
`306`		`- await this.VerifyCSharpFixAsync(ReferenceCode, fixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);`
	`306`	`+ await this.VerifyCSharpFixAsync(ReferenceCode, FixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@ private static async Task<SyntaxTreeAnalysisContext> CreateAnalysisContextAsync(`
`375`	`375`
`376`	`376`	`private class AdditionalTextHelper : AdditionalText`
`377`	`377`	`{`
`378`		`- private SourceText sourceText;`
	`378`	`+ private readonly SourceText sourceText;`
`379`	`379`
`380`	`380`	`public AdditionalTextHelper(string path, string text)`
`381`	`381`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ namespace LightJson`
`15`	`15`	`[DebuggerTypeProxy(typeof(JsonArrayDebugView))]`
`16`	`16`	`internal sealed class JsonArray : IEnumerable<JsonValue>`
`17`	`17`	`{`
`18`		`- private IList<JsonValue> items;`
	`18`	`+ private readonly IList<JsonValue> items;`
`19`	`19`
`20`	`20`	`/// <summary>`
`21`	`21`	`/// Initializes a new instance of the <see cref="JsonArray"/> class.`
`@@ -167,7 +167,7 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()`
`167`	`167`	`[ExcludeFromCodeCoverage]`
`168`	`168`	`private class JsonArrayDebugView`
`169`	`169`	`{`
`170`		`- private JsonArray jsonArray;`
	`170`	`+ private readonly JsonArray jsonArray;`
`171`	`171`
`172`	`172`	`public JsonArrayDebugView(JsonArray jsonArray)`
`173`	`173`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ namespace LightJson`
`14`	`14`	`[DebuggerTypeProxy(typeof(JsonObjectDebugView))]`
`15`	`15`	`internal sealed class JsonObject : IEnumerable<KeyValuePair<string, JsonValue>>, IEnumerable<JsonValue>`
`16`	`16`	`{`
`17`		`- private IDictionary<string, JsonValue> properties;`
	`17`	`+ private readonly IDictionary<string, JsonValue> properties;`
`18`	`18`
`19`	`19`	`/// <summary>`
`20`	`20`	`/// Initializes a new instance of the <see cref="JsonObject"/> class.`
`@@ -189,7 +189,7 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()`
`189`	`189`	`[ExcludeFromCodeCoverage]`
`190`	`190`	`private class JsonObjectDebugView`
`191`	`191`	`{`
`192`		`- private JsonObject jsonObject;`
	`192`	`+ private readonly JsonObject jsonObject;`
`193`	`193`
`194`	`194`	`public JsonObjectDebugView(JsonObject jsonObject)`
`195`	`195`	`{`
`@@ -218,10 +218,10 @@ public KeyValuePair[] Keys`
`218`	`218`	`public class KeyValuePair`
`219`	`219`	`{`
`220`	`220`	`[DebuggerBrowsable(DebuggerBrowsableState.Never)]`
`221`		`- private string key;`
	`221`	`+ private readonly string key;`
`222`	`222`
`223`	`223`	`[DebuggerBrowsable(DebuggerBrowsableState.Never)]`
`224`		`- private JsonValue value;`
	`224`	`+ private readonly JsonValue value;`
`225`	`225`
`226`	`226`	`public KeyValuePair(string key, JsonValue value)`
`227`	`227`	`{`
Original file line number	Diff line number	Diff line change
`@@ -839,7 +839,7 @@ public override int GetHashCode()`
`839`	`839`	`[ExcludeFromCodeCoverage]`
`840`	`840`	`private class JsonValueDebugView`
`841`	`841`	`{`
`842`		`- private JsonValue jsonValue;`
	`842`	`+ private readonly JsonValue jsonValue;`
`843`	`843`
`844`	`844`	`public JsonValueDebugView(JsonValue jsonValue)`
`845`	`845`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ namespace LightJson.Serialization`
`14`	`14`	`/// </summary>`
`15`	`15`	`internal sealed class JsonReader`
`16`	`16`	`{`
`17`		`- private TextScanner scanner;`
	`17`	`+ private readonly TextScanner scanner;`
`18`	`18`
`19`	`19`	`private JsonReader(TextReader reader)`
`20`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace LightJson.Serialization`
`11`	`11`	`/// </summary>`
`12`	`12`	`internal sealed class TextScanner`
`13`	`13`	`{`
`14`		`- private TextReader reader;`
	`14`	`+ private readonly TextReader reader;`
`15`	`15`	`private TextPosition position;`
`16`	`16`
`17`	`17`	`/// <summary>`