Merge pull request #2557 from sharwell/rm-helper

Remove unnecessary method FixAllContextHelper.GetAllDiagnosticsAsync

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Helpers/FixAllContextHelper.cs

@@ -119,11 +119,6 @@ public static async Task<ImmutableDictionary<Project, ImmutableArray<Diagnostic>
             return ImmutableDictionary<Project, ImmutableArray<Diagnostic>>.Empty;
         }
 
-        public static async Task<ImmutableArray<Diagnostic>> GetAllDiagnosticsAsync(Compilation compilation, CompilationWithAnalyzers compilationWithAnalyzers, ImmutableArray<DiagnosticAnalyzer> analyzers, IEnumerable<Document> documents, bool includeCompilerDiagnostics, CancellationToken cancellationToken)
-        {
-            return await compilationWithAnalyzers.GetAllDiagnosticsAsync(cancellationToken).ConfigureAwait(false);
-        }
-
         /// <summary>
         /// Gets all <see cref="Diagnostic"/> instances within a specific <see cref="Project"/> which are relevant to a
         /// <see cref="FixAllContext"/>.

StyleCop.Analyzers/StyleCopTester/Program.cs

@@ -19,8 +19,6 @@ namespace StyleCopTester
     using Microsoft.CodeAnalysis.CodeFixes;
     using Microsoft.CodeAnalysis.Diagnostics;
     using Microsoft.CodeAnalysis.MSBuild;
-    using Microsoft.CodeAnalysis.Text;
-    using StyleCop.Analyzers.Helpers;
     using File = System.IO.File;
     using Path = System.IO.Path;
 
@@ -482,7 +480,7 @@ private static async Task<ImmutableArray<Diagnostic>> GetProjectAnalyzerDiagnost
             Compilation compilation = await processedProject.GetCompilationAsync(cancellationToken).ConfigureAwait(false);
             CompilationWithAnalyzers compilationWithAnalyzers = compilation.WithAnalyzers(analyzers, new CompilationWithAnalyzersOptions(new AnalyzerOptions(ImmutableArray.Create<AdditionalText>()), null, true, false));
 
-            var diagnostics = await FixAllContextHelper.GetAllDiagnosticsAsync(compilation, compilationWithAnalyzers, analyzers, project.Documents, true, cancellationToken).ConfigureAwait(false);
+            var diagnostics = await compilationWithAnalyzers.GetAllDiagnosticsAsync(cancellationToken).ConfigureAwait(false);
             return diagnostics;
         }