Use nameof instead of literals where applicable

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1642SA1643CodeFixProvider.cs

@@ -99,29 +99,29 @@ private static Task<Document> GetTransformedDocumentAsync(Document document, Syn
             ImmutableArray<string> standardText;
             if (declarationSyntax is ConstructorDeclarationSyntax)
             {
-                var typeKindText = resourceManager.GetString(isStruct ? "TypeTextStruct" : "TypeTextClass", culture);
+                var typeKindText = resourceManager.GetString(isStruct ? nameof(DocumentationResources.TypeTextStruct) : nameof(DocumentationResources.TypeTextClass), culture);
                 if (declarationSyntax.Modifiers.Any(SyntaxKind.StaticKeyword))
                 {
                     standardText = ImmutableArray.Create(
-                        string.Format(resourceManager.GetString("StaticConstructorStandardTextFirstPart", culture), typeKindText),
-                        string.Format(resourceManager.GetString("StaticConstructorStandardTextSecondPart", culture), typeKindText));
+                        string.Format(resourceManager.GetString(nameof(DocumentationResources.StaticConstructorStandardTextFirstPart), culture), typeKindText),
+                        string.Format(resourceManager.GetString(nameof(DocumentationResources.StaticConstructorStandardTextSecondPart), culture), typeKindText));
                 }
                 else
                 {
                     // Prefer to insert the "non-private" wording for all constructors, even though both are considered
                     // acceptable for private constructors by the diagnostic.
                     // https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/413
                     standardText = ImmutableArray.Create(
-                        string.Format(resourceManager.GetString("NonPrivateConstructorStandardTextFirstPart", culture), typeKindText),
-                        string.Format(resourceManager.GetString("NonPrivateConstructorStandardTextSecondPart", culture), typeKindText));
+                        string.Format(resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextFirstPart), culture), typeKindText),
+                        string.Format(resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextSecondPart), culture), typeKindText));
                 }
             }
             else if (declarationSyntax is DestructorDeclarationSyntax)
             {
                 standardText =
                     ImmutableArray.Create(
-                        resourceManager.GetString("DestructorStandardTextFirstPart", culture),
-                        resourceManager.GetString("DestructorStandardTextSecondPart", culture));
+                        resourceManager.GetString(nameof(DocumentationResources.DestructorStandardTextFirstPart), culture),
+                        resourceManager.GetString(nameof(DocumentationResources.DestructorStandardTextSecondPart), culture));
             }
             else
             {

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PropertySummaryDocumentationAnalyzer.cs

@@ -72,9 +72,9 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, XmlN
                     syntax,
                     diagnosticLocation,
                     propertyDeclaration,
-                    resourceManager.GetString("StartingTextGetsWhether", culture),
-                    resourceManager.GetString("StartingTextSetsWhether", culture),
-                    resourceManager.GetString("StartingTextGetsOrSetsWhether", culture));
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextGetsWhether), culture),
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextSetsWhether), culture),
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextGetsOrSetsWhether), culture));
             }
             else
             {
@@ -83,9 +83,9 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, XmlN
                     syntax,
                     diagnosticLocation,
                     propertyDeclaration,
-                    resourceManager.GetString("StartingTextGets", culture),
-                    resourceManager.GetString("StartingTextSets", culture),
-                    resourceManager.GetString("StartingTextGetsOrSets", culture));
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextGets), culture),
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextSets), culture),
+                    resourceManager.GetString(nameof(DocumentationResources.StartingTextGetsOrSets), culture));
             }
         }
 

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642ConstructorSummaryDocumentationMustBeginWithStandardText.cs

@@ -132,23 +132,23 @@ private static void HandleConstructorDeclaration(SyntaxNodeAnalysisContext conte
             var resourceManager = DocumentationResources.ResourceManager;
 
             bool isStruct = constructorDeclarationSyntax.Parent?.IsKind(SyntaxKind.StructDeclaration) ?? false;
-            var typeKindText = resourceManager.GetString(isStruct ? "TypeTextStruct" : "TypeTextClass", culture);
+            var typeKindText = resourceManager.GetString(isStruct ? nameof(DocumentationResources.TypeTextStruct) : nameof(DocumentationResources.TypeTextClass), culture);
 
             if (constructorDeclarationSyntax.Modifiers.Any(SyntaxKind.StaticKeyword))
             {
                 HandleDeclaration(
                     context,
-                    string.Format(resourceManager.GetString("StaticConstructorStandardTextFirstPart", culture), typeKindText),
-                    string.Format(resourceManager.GetString("StaticConstructorStandardTextSecondPart", culture), typeKindText),
+                    string.Format(resourceManager.GetString(nameof(DocumentationResources.StaticConstructorStandardTextFirstPart), culture), typeKindText),
+                    string.Format(resourceManager.GetString(nameof(DocumentationResources.StaticConstructorStandardTextSecondPart), culture), typeKindText),
                     Descriptor);
             }
             else if (constructorDeclarationSyntax.Modifiers.Any(SyntaxKind.PrivateKeyword))
             {
                 var privateConstructorMatch = HandleDeclaration(
                     context,
-                    string.Format(resourceManager.GetString("PrivateConstructorStandardTextFirstPart", culture), typeKindText),
+                    string.Format(resourceManager.GetString(nameof(DocumentationResources.PrivateConstructorStandardTextFirstPart), culture), typeKindText),
                     string.Format(
-                        resourceManager.GetString("PrivateConstructorStandardTextSecondPart", culture),
+                        resourceManager.GetString(nameof(DocumentationResources.PrivateConstructorStandardTextSecondPart), culture),
                         typeKindText),
                     null);
 
@@ -161,10 +161,10 @@ private static void HandleConstructorDeclaration(SyntaxNodeAnalysisContext conte
                 HandleDeclaration(
                     context,
                     string.Format(
-                        resourceManager.GetString("NonPrivateConstructorStandardTextFirstPart", culture),
+                        resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextFirstPart), culture),
                         typeKindText),
                     string.Format(
-                        resourceManager.GetString("NonPrivateConstructorStandardTextSecondPart", culture),
+                        resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextSecondPart), culture),
                         typeKindText),
                     Descriptor);
             }
@@ -173,10 +173,10 @@ private static void HandleConstructorDeclaration(SyntaxNodeAnalysisContext conte
                 HandleDeclaration(
                     context,
                     string.Format(
-                        resourceManager.GetString("NonPrivateConstructorStandardTextFirstPart", culture),
+                        resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextFirstPart), culture),
                         typeKindText),
                     string.Format(
-                        resourceManager.GetString("NonPrivateConstructorStandardTextSecondPart", culture),
+                        resourceManager.GetString(nameof(DocumentationResources.NonPrivateConstructorStandardTextSecondPart), culture),
                         typeKindText),
                     Descriptor);
             }

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1643DestructorSummaryDocumentationMustBeginWithStandardText.cs

@@ -91,8 +91,8 @@ private static void HandleDestructor(SyntaxNodeAnalysisContext context)
 
                 HandleDeclaration(
                     context,
-                    resourceManager.GetString("DestructorStandardTextFirstPart", culture),
-                    resourceManager.GetString("DestructorStandardTextSecondPart", culture),
+                    resourceManager.GetString(nameof(DocumentationResources.DestructorStandardTextFirstPart), culture),
+                    resourceManager.GetString(nameof(DocumentationResources.DestructorStandardTextSecondPart), culture),
                     Descriptor);
             }
         }