Skip to content

Commit 741c152

Browse files
committed
IDE0019 Use pattern matching
1 parent e0f8d7a commit 741c152

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Helpers/RenameHelper.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,7 @@ public static SyntaxNode GetParentDeclaration(SyntaxToken token)
162162
return parent;
163163

164164
default:
165-
var declarationParent = parent as MemberDeclarationSyntax;
166-
if (declarationParent != null)
165+
if (parent is MemberDeclarationSyntax declarationParent)
167166
{
168167
return declarationParent;
169168
}

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1122UseStringEmptyForEmptyStrings.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,7 @@ private static bool HasToBeConstant(LiteralExpressionSyntax literalExpression)
9393
return true;
9494
}
9595

96-
VariableDeclaratorSyntax variableDeclaratorSyntax = equalsValueClause.Parent as VariableDeclaratorSyntax;
97-
VariableDeclarationSyntax variableDeclarationSyntax = variableDeclaratorSyntax?.Parent as VariableDeclarationSyntax;
98-
if (variableDeclaratorSyntax == null || variableDeclarationSyntax == null)
96+
if (!(equalsValueClause.Parent is VariableDeclaratorSyntax variableDeclaratorSyntax) || !(variableDeclaratorSyntax?.Parent is VariableDeclarationSyntax variableDeclarationSyntax))
9997
{
10098
return false;
10199
}

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1130UseLambdaSyntax.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,7 @@ private static void HandleAnonymousMethodExpression(SyntaxNodeAnalysisContext co
128128
private static bool HandleMethodInvocation(SemanticModel semanticModel, AnonymousMethodExpressionSyntax anonymousMethod, ArgumentSyntax argumentSyntax)
129129
{
130130
// invocation -> argument list -> argument -> anonymous method
131-
var argumentListSyntax = argumentSyntax?.Parent as BaseArgumentListSyntax;
132-
133-
if (argumentListSyntax != null)
131+
if (argumentSyntax?.Parent is BaseArgumentListSyntax argumentListSyntax)
134132
{
135133
var originalInvocableExpression = argumentListSyntax.Parent;
136134
SymbolInfo originalSymbolInfo = semanticModel.GetSymbolInfo(originalInvocableExpression);

0 commit comments

Comments
 (0)