Fix SA1629 and SA1608 reporting for interfaces

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1608UnitTests.cs

@@ -111,16 +111,19 @@ public async Task TestTypeWithoutContentDocumentationAsync(string typeName)
             await this.VerifyCSharpDiagnosticAsync(string.Format(testCode, typeName), EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
-        [Fact]
-        public async Task TestClassWithDefaultDocumentationAsync()
+        [Theory]
+        [InlineData("class")]
+        [InlineData("struct")]
+        [InlineData("interface")]
+        public async Task TestTypeWithDefaultDocumentationAsync(string typeName)
         {
-            var testCode = @"
+            var testCode = $@"
 /// <summary>
 /// Summary description for the ClassName class.
 /// </summary>
-public class ClassName
-{
-}";
+public {typeName} ClassName
+{{
+}}";
 
             DiagnosticResult expected = this.CSharpDiagnostic().WithLocation(2, 5);
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1629UnitTests.cs

@@ -314,7 +314,7 @@ public interface ITest
 
             var fixedTestCode = @"
 /// <summary>
-/// Test interface <see cref=""ITest""/>
+/// Test interface <see cref=""ITest""/>.
 /// </summary>
 public interface ITest
 {
@@ -325,7 +325,11 @@ public interface ITest
 }
 ";
 
-            DiagnosticResult expected = this.CSharpDiagnostic().WithLocation(8, 41);
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation(3, 39),
+                this.CSharpDiagnostic().WithLocation(8, 41),
+            };
 
             await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
             await this.VerifyCSharpDiagnosticAsync(fixedTestCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationBase.cs

@@ -30,6 +30,7 @@ internal abstract class ElementDocumentationBase : DiagnosticAnalyzer
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> conversionOperatorDeclarationAction;
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> classDeclarationAction;
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> structDeclarationAction;
+        private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> interfaceDeclarationAction;
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> enumDeclarationAction;
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> fieldDeclarationAction;
         private readonly Action<SyntaxNodeAnalysisContext, StyleCopSettings> propertyDeclarationAction;
@@ -47,6 +48,7 @@ protected ElementDocumentationBase(bool inheritDocSuppressesWarnings, string mat
             this.conversionOperatorDeclarationAction = this.HandleConversionOperatorDeclaration;
             this.classDeclarationAction = this.HandleClassDeclaration;
             this.structDeclarationAction = this.HandleStructDeclaration;
+            this.interfaceDeclarationAction = this.HandleInterfaceDeclaration;
             this.enumDeclarationAction = this.HandleEnumDeclaration;
             this.fieldDeclarationAction = this.HandleFieldDeclaration;
             this.propertyDeclarationAction = this.HandlePropertyDeclaration;
@@ -66,6 +68,7 @@ public override void Initialize(AnalysisContext context)
             context.RegisterSyntaxNodeAction(this.conversionOperatorDeclarationAction, SyntaxKind.ConversionOperatorDeclaration);
             context.RegisterSyntaxNodeAction(this.classDeclarationAction, SyntaxKind.ClassDeclaration);
             context.RegisterSyntaxNodeAction(this.structDeclarationAction, SyntaxKind.StructDeclaration);
+            context.RegisterSyntaxNodeAction(this.interfaceDeclarationAction, SyntaxKind.InterfaceDeclaration);
             context.RegisterSyntaxNodeAction(this.enumDeclarationAction, SyntaxKind.EnumDeclaration);
             context.RegisterSyntaxNodeAction(this.fieldDeclarationAction, SyntaxKind.FieldDeclaration);
             context.RegisterSyntaxNodeAction(this.propertyDeclarationAction, SyntaxKind.PropertyDeclaration);
@@ -195,6 +198,16 @@ private void HandleStructDeclaration(SyntaxNodeAnalysisContext context, StyleCop
             this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
         }
 
+        private void HandleInterfaceDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
+        {
+            var node = (InterfaceDeclarationSyntax)context.Node;
+
+            Accessibility declaredAccessibility = node.GetDeclaredAccessibility(context.SemanticModel, context.CancellationToken);
+            Accessibility effectiveAccessibility = node.GetEffectiveAccessibility(context.SemanticModel, context.CancellationToken);
+            bool needsComment = SA1600ElementsMustBeDocumented.NeedsComment(settings.DocumentationRules, node.Kind(), node.Parent.Kind(), declaredAccessibility, effectiveAccessibility);
+            this.HandleDeclaration(context, needsComment, node, node.Identifier.GetLocation());
+        }
+
         private void HandleEnumDeclaration(SyntaxNodeAnalysisContext context, StyleCopSettings settings)
         {
             var node = (EnumDeclarationSyntax)context.Node;