Add special cases for the SA1129 code fix

* IntPtr.Zero
* UIntPtr.Zero
* Guid.Empty

Fixes #3065

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1129CodeFixProvider.cs

@@ -6,6 +6,7 @@ namespace StyleCop.Analyzers.ReadabilityRules
     using System;
     using System.Collections.Immutable;
     using System.Composition;
+    using System.Diagnostics;
     using System.Linq;
     using System.Threading;
     using System.Threading.Tasks;
@@ -67,15 +68,37 @@ private static SyntaxNode GetReplacementNode(SyntaxNode node, SemanticModel sema
 
             SyntaxNode replacement;
 
-            if (IsType<CancellationToken>(namedTypeSymbol))
+            if (IsType<CancellationToken>(namedTypeSymbol)
+                || namedTypeSymbol?.SpecialType == SpecialType.System_IntPtr
+                || namedTypeSymbol?.SpecialType == SpecialType.System_UIntPtr
+                || IsType<Guid>(namedTypeSymbol))
             {
                 if (IsDefaultParameterValue(newExpression))
                 {
                     replacement = SyntaxFactory.DefaultExpression(newExpression.Type);
                 }
                 else
                 {
-                    replacement = ConstructMemberAccessSyntax(newExpression.Type, nameof(CancellationToken.None));
+                    string fieldName;
+                    if (IsType<CancellationToken>(namedTypeSymbol))
+                    {
+                        fieldName = nameof(CancellationToken.None);
+                    }
+                    else if (namedTypeSymbol.SpecialType == SpecialType.System_IntPtr)
+                    {
+                        fieldName = nameof(IntPtr.Zero);
+                    }
+                    else if (namedTypeSymbol.SpecialType == SpecialType.System_UIntPtr)
+                    {
+                        fieldName = nameof(IntPtr.Zero);
+                    }
+                    else
+                    {
+                        Debug.Assert(IsType<Guid>(namedTypeSymbol), "Assertion failed: IsType<Guid>(namedTypeSymbol)");
+                        fieldName = nameof(Guid.Empty);
+                    }
+
+                    replacement = ConstructMemberAccessSyntax(newExpression.Type, fieldName);
                 }
             }
             else if (IsEnumWithDefaultMember(namedTypeSymbol, out string memberName))

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1129UnitTests.cs

@@ -3,6 +3,7 @@
 
 namespace StyleCop.Analyzers.Test.ReadabilityRules
 {
+    using System;
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis.Testing;
@@ -241,6 +242,9 @@ public T TestMethod2<T>()
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData("System.Threading", nameof(CancellationToken), nameof(CancellationToken.None))]
+        [InlineData("System", nameof(IntPtr), nameof(IntPtr.Zero))]
+        [InlineData("System", nameof(UIntPtr), nameof(UIntPtr.Zero))]
+        [InlineData("System", nameof(Guid), nameof(Guid.Empty))]
         public async Task VerifySpecialTypeFixUsesSpecialSyntaxAsync(string typeNamespace, string typeName, string fieldName)
         {
             var testCode = $@"
@@ -279,6 +283,9 @@ public void TestMethod()
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData("System.Threading", nameof(CancellationToken), nameof(CancellationToken.None))]
+        [InlineData("System", nameof(IntPtr), nameof(IntPtr.Zero))]
+        [InlineData("System", nameof(UIntPtr), nameof(UIntPtr.Zero))]
+        [InlineData("System", nameof(Guid), nameof(Guid.Empty))]
         public async Task VerifySpecialTypeTriviaPreservationAsync(string typeNamespace, string typeName, string fieldName)
         {
             var testCode = $@"
@@ -318,6 +325,9 @@ public void TestMethod()
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData("System.Threading", nameof(CancellationToken), nameof(CancellationToken.None))]
+        [InlineData("System", nameof(IntPtr), nameof(IntPtr.Zero))]
+        [InlineData("System", nameof(UIntPtr), nameof(UIntPtr.Zero))]
+        [InlineData("System", nameof(Guid), nameof(Guid.Empty))]
         public async Task VerifyQualifiedSpecialTypeFixUsesFieldSyntaxAsync(string typeNamespace, string typeName, string fieldName)
         {
             var testCode = $@"
@@ -351,6 +361,9 @@ public void TestMethod()
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData(nameof(CancellationToken))]
+        [InlineData(nameof(IntPtr))]
+        [InlineData(nameof(UIntPtr))]
+        [InlineData(nameof(Guid))]
         public async Task VerifyCustomSpecialTypeStructIsNotReplacedAsync(string typeName)
         {
             var testCode = $@"public class TestClass
@@ -394,6 +407,9 @@ private struct {typeName}
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData("System.Threading", nameof(CancellationToken), nameof(CancellationToken.None))]
+        [InlineData("System", nameof(IntPtr), nameof(IntPtr.Zero))]
+        [InlineData("System", nameof(UIntPtr), nameof(UIntPtr.Zero))]
+        [InlineData("System", nameof(Guid), nameof(Guid.Empty))]
         public async Task VerifyAliasedSpecialTypeUsesFieldSyntaxAsync(string typeNamespace, string typeName, string fieldName)
         {
             var testCode = $@"
@@ -508,6 +524,9 @@ private enum MyEnum {{ {declarationBody} }}
         /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
         [Theory]
         [InlineData("System.Threading", nameof(CancellationToken))]
+        [InlineData("System", nameof(IntPtr))]
+        [InlineData("System", nameof(UIntPtr))]
+        [InlineData("System", nameof(Guid))]
         [WorkItem(2740, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2740")]
         public async Task VerifySpecialTypeDefaultParameterAsync(string typeNamespace, string typeName)
         {