Skip to content

Commit 82588c3

Browse files
vweijstersvweijsters
committed
Implemented missing parameter validation in separated syntax list accessor helper
1 parent baeb126 commit 82588c3

22 files changed

Lines changed: 206 additions & 159 deletions

‎StyleCop.Analyzers/StyleCop.Analyzers.Test/Lightup/LightupHelpersTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void TestCreateSeparatedSyntaxListPropertyAccessor()
6767
Assert.ThrowsAny<InvalidOperationException>(() => LightupHelpers.CreateSeparatedSyntaxListPropertyAccessor<ParameterListSyntax, ParameterSyntax>(typeof(BaseParameterListSyntax), nameof(BaseParameterListSyntax.Parameters)));
6868
}
6969

70-
[Fact(Skip = "Validation is not currently performed for the second argument.")]
70+
[Fact]
7171
public void TestCreateSeparatedSyntaxListPropertyAccessorValidateElementType()
7272
{
7373
// The call *should* have been made with the second generic argument set to `ParameterSyntax`
@@ -98,7 +98,7 @@ public void TestCreateSeparatedSyntaxListWithPropertyAccessor()
9898
Assert.ThrowsAny<InvalidOperationException>(() => LightupHelpers.CreateSeparatedSyntaxListWithPropertyAccessor<ParameterListSyntax, ParameterSyntax>(typeof(BaseParameterListSyntax), nameof(BaseParameterListSyntax.Parameters)));
9999
}
100100

101-
[Fact(Skip = "Validation is not currently performed for the second argument.")]
101+
[Fact]
102102
public void TestCreateSeparatedSyntaxListWithPropertyAccessorValidateElementType()
103103
{
104104
// The call *should* have been made with the second generic argument set to `ParameterSyntax`

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/CasePatternSwitchLabelSyntaxWrapper.cs‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace StyleCop.Analyzers.Lightup
1212
internal struct CasePatternSwitchLabelSyntaxWrapper : ISyntaxWrapper<SwitchLabelSyntax>
1313
{
1414
private const string CasePatternSwitchLabelSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.CasePatternSwitchLabelSyntax";
15-
private static readonly Type CasePatternSwitchLabelSyntaxType;
1615

1716
private static readonly Func<SwitchLabelSyntax, CSharpSyntaxNode> PatternAccessor;
1817
private static readonly Func<SwitchLabelSyntax, CSharpSyntaxNode> WhenClauseAccessor;
@@ -25,20 +24,22 @@ internal struct CasePatternSwitchLabelSyntaxWrapper : ISyntaxWrapper<SwitchLabel
2524

2625
static CasePatternSwitchLabelSyntaxWrapper()
2726
{
28-
CasePatternSwitchLabelSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(CasePatternSwitchLabelSyntaxTypeName);
29-
PatternAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(CasePatternSwitchLabelSyntaxType, nameof(Pattern));
30-
WhenClauseAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(CasePatternSwitchLabelSyntaxType, nameof(WhenClause));
31-
WithKeywordAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, SyntaxToken>(CasePatternSwitchLabelSyntaxType, nameof(SwitchLabelSyntax.Keyword));
32-
WithColonTokenAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, SyntaxToken>(CasePatternSwitchLabelSyntaxType, nameof(SwitchLabelSyntax.ColonToken));
33-
WithPatternAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(CasePatternSwitchLabelSyntaxType, nameof(Pattern));
34-
WithWhenClauseAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(CasePatternSwitchLabelSyntaxType, nameof(WhenClause));
27+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(CasePatternSwitchLabelSyntaxTypeName);
28+
PatternAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(WrappedType, nameof(Pattern));
29+
WhenClauseAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(WrappedType, nameof(WhenClause));
30+
WithKeywordAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, SyntaxToken>(WrappedType, nameof(SwitchLabelSyntax.Keyword));
31+
WithColonTokenAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, SyntaxToken>(WrappedType, nameof(SwitchLabelSyntax.ColonToken));
32+
WithPatternAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(WrappedType, nameof(Pattern));
33+
WithWhenClauseAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<SwitchLabelSyntax, CSharpSyntaxNode>(WrappedType, nameof(WhenClause));
3534
}
3635

3736
private CasePatternSwitchLabelSyntaxWrapper(SwitchLabelSyntax node)
3837
{
3938
this.node = node;
4039
}
4140

41+
public static Type WrappedType { get; private set; }
42+
4243
public SwitchLabelSyntax SyntaxNode => this.node;
4344

4445
public PatternSyntaxWrapper Pattern
@@ -79,7 +80,7 @@ public static implicit operator SwitchLabelSyntax(CasePatternSwitchLabelSyntaxWr
7980

8081
public static bool IsInstance(SyntaxNode node)
8182
{
82-
return node != null && LightupHelpers.CanWrapNode(node, CasePatternSwitchLabelSyntaxType);
83+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
8384
}
8485

8586
public CasePatternSwitchLabelSyntaxWrapper WithKeyword(SyntaxToken keyword)

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/CommonForEachStatementSyntaxWrapper.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ internal struct CommonForEachStatementSyntaxWrapper : ISyntaxWrapper<StatementSy
2020
/// </summary>
2121
private const string ForEachStatementSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.CommonForEachStatementSyntax";
2222

23-
private static readonly Type CommonForEachStatementSyntaxType;
24-
2523
private static readonly Func<StatementSyntax, SyntaxToken> ForEachKeywordAccessor;
2624
private static readonly Func<StatementSyntax, SyntaxToken> OpenParenTokenAccessor;
2725
private static readonly Func<StatementSyntax, SyntaxToken> InKeywordAccessor;
@@ -33,21 +31,23 @@ internal struct CommonForEachStatementSyntaxWrapper : ISyntaxWrapper<StatementSy
3331

3432
static CommonForEachStatementSyntaxWrapper()
3533
{
36-
CommonForEachStatementSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(CommonForEachStatementSyntaxTypeName)
34+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(CommonForEachStatementSyntaxTypeName)
3735
?? typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(ForEachStatementSyntaxTypeName);
38-
ForEachKeywordAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(CommonForEachStatementSyntaxType, nameof(ForEachKeyword));
39-
OpenParenTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(CommonForEachStatementSyntaxType, nameof(OpenParenToken));
40-
InKeywordAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(CommonForEachStatementSyntaxType, nameof(InKeyword));
41-
ExpressionAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, ExpressionSyntax>(CommonForEachStatementSyntaxType, nameof(Expression));
42-
CloseParenTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(CommonForEachStatementSyntaxType, nameof(CloseParenToken));
43-
StatementAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, StatementSyntax>(CommonForEachStatementSyntaxType, nameof(Statement));
36+
ForEachKeywordAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(WrappedType, nameof(ForEachKeyword));
37+
OpenParenTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(WrappedType, nameof(OpenParenToken));
38+
InKeywordAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(WrappedType, nameof(InKeyword));
39+
ExpressionAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, ExpressionSyntax>(WrappedType, nameof(Expression));
40+
CloseParenTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, SyntaxToken>(WrappedType, nameof(CloseParenToken));
41+
StatementAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<StatementSyntax, StatementSyntax>(WrappedType, nameof(Statement));
4442
}
4543

4644
private CommonForEachStatementSyntaxWrapper(StatementSyntax node)
4745
{
4846
this.node = node;
4947
}
5048

49+
public static Type WrappedType { get; private set; }
50+
5151
public StatementSyntax SyntaxNode => this.node;
5252

5353
public SyntaxToken ForEachKeyword
@@ -125,7 +125,7 @@ public static implicit operator StatementSyntax(CommonForEachStatementSyntaxWrap
125125

126126
public static bool IsInstance(SyntaxNode node)
127127
{
128-
return node != null && LightupHelpers.CanWrapNode(node, CommonForEachStatementSyntaxType);
128+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
129129
}
130130

131131
internal static CommonForEachStatementSyntaxWrapper FromUpcast(StatementSyntax node)

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/ConstantPatternSyntaxWrapper.cs‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace StyleCop.Analyzers.Lightup
1212
internal struct ConstantPatternSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNode>
1313
{
1414
private const string ConstantPatternSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.ConstantPatternSyntax";
15-
private static readonly Type ConstantPatternSyntaxType;
1615

1716
private static readonly Func<CSharpSyntaxNode, ExpressionSyntax> ExpressionAccessor;
1817
private static readonly Func<CSharpSyntaxNode, ExpressionSyntax, CSharpSyntaxNode> WithExpressionAccessor;
@@ -21,16 +20,18 @@ internal struct ConstantPatternSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNode>
2120

2221
static ConstantPatternSyntaxWrapper()
2322
{
24-
ConstantPatternSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(ConstantPatternSyntaxTypeName);
25-
ExpressionAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, ExpressionSyntax>(ConstantPatternSyntaxType, nameof(Expression));
26-
WithExpressionAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, ExpressionSyntax>(ConstantPatternSyntaxType, nameof(Expression));
23+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(ConstantPatternSyntaxTypeName);
24+
ExpressionAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, ExpressionSyntax>(WrappedType, nameof(Expression));
25+
WithExpressionAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, ExpressionSyntax>(WrappedType, nameof(Expression));
2726
}
2827

2928
private ConstantPatternSyntaxWrapper(CSharpSyntaxNode node)
3029
{
3130
this.node = node;
3231
}
3332

33+
public static Type WrappedType { get; private set; }
34+
3435
public CSharpSyntaxNode SyntaxNode => this.node;
3536

3637
public ExpressionSyntax Expression
@@ -73,7 +74,7 @@ public static implicit operator CSharpSyntaxNode(ConstantPatternSyntaxWrapper wr
7374

7475
public static bool IsInstance(SyntaxNode node)
7576
{
76-
return node != null && LightupHelpers.CanWrapNode(node, ConstantPatternSyntaxType);
77+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
7778
}
7879

7980
public ConstantPatternSyntaxWrapper WithExpression(ExpressionSyntax expression)

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/DeclarationExpressionSyntaxWrapper.cs‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace StyleCop.Analyzers.Lightup
1212
internal struct DeclarationExpressionSyntaxWrapper : ISyntaxWrapper<ExpressionSyntax>
1313
{
1414
private const string DeclarationExpressionSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.DeclarationExpressionSyntax";
15-
private static readonly Type DeclarationExpressionSyntaxType;
1615

1716
private static readonly Func<ExpressionSyntax, TypeSyntax> TypeAccessor;
1817
private static readonly Func<ExpressionSyntax, CSharpSyntaxNode> DesignationAccessor;
@@ -23,18 +22,20 @@ internal struct DeclarationExpressionSyntaxWrapper : ISyntaxWrapper<ExpressionSy
2322

2423
static DeclarationExpressionSyntaxWrapper()
2524
{
26-
DeclarationExpressionSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DeclarationExpressionSyntaxTypeName);
27-
TypeAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<ExpressionSyntax, TypeSyntax>(DeclarationExpressionSyntaxType, nameof(Type));
28-
DesignationAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<ExpressionSyntax, CSharpSyntaxNode>(DeclarationExpressionSyntaxType, nameof(Designation));
29-
WithTypeAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<ExpressionSyntax, TypeSyntax>(DeclarationExpressionSyntaxType, nameof(Type));
30-
WithDesignationAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<ExpressionSyntax, CSharpSyntaxNode>(DeclarationExpressionSyntaxType, nameof(Designation));
25+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DeclarationExpressionSyntaxTypeName);
26+
TypeAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<ExpressionSyntax, TypeSyntax>(WrappedType, nameof(Type));
27+
DesignationAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<ExpressionSyntax, CSharpSyntaxNode>(WrappedType, nameof(Designation));
28+
WithTypeAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<ExpressionSyntax, TypeSyntax>(WrappedType, nameof(Type));
29+
WithDesignationAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<ExpressionSyntax, CSharpSyntaxNode>(WrappedType, nameof(Designation));
3130
}
3231

3332
private DeclarationExpressionSyntaxWrapper(ExpressionSyntax node)
3433
{
3534
this.node = node;
3635
}
3736

37+
public static Type WrappedType { get; private set; }
38+
3839
public ExpressionSyntax SyntaxNode => this.node;
3940

4041
public TypeSyntax Type
@@ -75,7 +76,7 @@ public static implicit operator ExpressionSyntax(DeclarationExpressionSyntaxWrap
7576

7677
public static bool IsInstance(SyntaxNode node)
7778
{
78-
return node != null && LightupHelpers.CanWrapNode(node, DeclarationExpressionSyntaxType);
79+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
7980
}
8081

8182
public DeclarationExpressionSyntaxWrapper WithType(TypeSyntax type)

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/DeclarationPatternSyntaxWrapper.cs‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ namespace StyleCop.Analyzers.Lightup
1212
internal struct DeclarationPatternSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNode>
1313
{
1414
private const string DeclarationPatternSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.DeclarationPatternSyntax";
15-
private static readonly Type DeclarationPatternSyntaxType;
1615

1716
private static readonly Func<CSharpSyntaxNode, TypeSyntax> TypeAccessor;
1817
private static readonly Func<CSharpSyntaxNode, CSharpSyntaxNode> DesignationAccessor;
@@ -23,18 +22,20 @@ internal struct DeclarationPatternSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNod
2322

2423
static DeclarationPatternSyntaxWrapper()
2524
{
26-
DeclarationPatternSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DeclarationPatternSyntaxTypeName);
27-
TypeAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, TypeSyntax>(DeclarationPatternSyntaxType, nameof(Type));
28-
DesignationAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, CSharpSyntaxNode>(DeclarationPatternSyntaxType, nameof(Designation));
29-
WithTypeAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, TypeSyntax>(DeclarationPatternSyntaxType, nameof(Type));
30-
WithDesignationAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, CSharpSyntaxNode>(DeclarationPatternSyntaxType, nameof(Designation));
25+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DeclarationPatternSyntaxTypeName);
26+
TypeAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, TypeSyntax>(WrappedType, nameof(Type));
27+
DesignationAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, CSharpSyntaxNode>(WrappedType, nameof(Designation));
28+
WithTypeAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, TypeSyntax>(WrappedType, nameof(Type));
29+
WithDesignationAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, CSharpSyntaxNode>(WrappedType, nameof(Designation));
3130
}
3231

3332
private DeclarationPatternSyntaxWrapper(CSharpSyntaxNode node)
3433
{
3534
this.node = node;
3635
}
3736

37+
public static Type WrappedType { get; private set; }
38+
3839
public CSharpSyntaxNode SyntaxNode => this.node;
3940

4041
public TypeSyntax Type
@@ -85,7 +86,7 @@ public static implicit operator CSharpSyntaxNode(DeclarationPatternSyntaxWrapper
8586

8687
public static bool IsInstance(SyntaxNode node)
8788
{
88-
return node != null && LightupHelpers.CanWrapNode(node, DeclarationPatternSyntaxType);
89+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
8990
}
9091

9192
public DeclarationPatternSyntaxWrapper WithType(TypeSyntax type)

‎StyleCop.Analyzers/StyleCop.Analyzers/Lightup/DiscardDesignationSyntaxWrapper.cs‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ namespace StyleCop.Analyzers.Lightup
1111
internal struct DiscardDesignationSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNode>
1212
{
1313
private const string DiscardDesignationSyntaxTypeName = "Microsoft.CodeAnalysis.CSharp.Syntax.DiscardDesignationSyntax";
14-
private static readonly Type DiscardDesignationSyntaxType;
1514

1615
private static readonly Func<CSharpSyntaxNode, SyntaxToken> UnderscoreTokenAccessor;
1716
private static readonly Func<CSharpSyntaxNode, SyntaxToken, CSharpSyntaxNode> WithUnderscoreTokenAccessor;
@@ -20,16 +19,18 @@ internal struct DiscardDesignationSyntaxWrapper : ISyntaxWrapper<CSharpSyntaxNod
2019

2120
static DiscardDesignationSyntaxWrapper()
2221
{
23-
DiscardDesignationSyntaxType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DiscardDesignationSyntaxTypeName);
24-
UnderscoreTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, SyntaxToken>(DiscardDesignationSyntaxType, nameof(UnderscoreToken));
25-
WithUnderscoreTokenAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, SyntaxToken>(DiscardDesignationSyntaxType, nameof(UnderscoreToken));
22+
WrappedType = typeof(CSharpSyntaxNode).GetTypeInfo().Assembly.GetType(DiscardDesignationSyntaxTypeName);
23+
UnderscoreTokenAccessor = LightupHelpers.CreateSyntaxPropertyAccessor<CSharpSyntaxNode, SyntaxToken>(WrappedType, nameof(UnderscoreToken));
24+
WithUnderscoreTokenAccessor = LightupHelpers.CreateSyntaxWithPropertyAccessor<CSharpSyntaxNode, SyntaxToken>(WrappedType, nameof(UnderscoreToken));
2625
}
2726

2827
private DiscardDesignationSyntaxWrapper(CSharpSyntaxNode node)
2928
{
3029
this.node = node;
3130
}
3231

32+
public static Type WrappedType { get; private set; }
33+
3334
public CSharpSyntaxNode SyntaxNode => this.node;
3435

3536
public SyntaxToken UnderscoreToken
@@ -72,7 +73,7 @@ public static implicit operator CSharpSyntaxNode(DiscardDesignationSyntaxWrapper
7273

7374
public static bool IsInstance(SyntaxNode node)
7475
{
75-
return node != null && LightupHelpers.CanWrapNode(node, DiscardDesignationSyntaxType);
76+
return node != null && LightupHelpers.CanWrapNode(node, WrappedType);
7677
}
7778

7879
public DiscardDesignationSyntaxWrapper WithUnderscoreToken(SyntaxToken identifier)

0 commit comments

Comments
 (0)