Add SA1623/SA1624 tests for expression-bodied members

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1623UnitTests.cs

@@ -32,11 +32,15 @@ public class SA1623UnitTests : CodeFixVerifier
         [InlineData("public", "int", "{ get; internal set; }", "Gets")]
         [InlineData("public", "int", "{ get; private set; }", "Gets")]
         [InlineData("public", "int", "{ get; }", "Gets")]
+        [InlineData("public", "int", "{ get; } = 0;", "Gets")]
+        [InlineData("public", "int", "=> 0;", "Gets")]
         [InlineData("public", "int", "{ set { } }", "Sets")]
         [InlineData("public", "int", "{ internal get { return 0; } set { } }", "Sets")]
         [InlineData("public", "int", "{ private get { return 0; } set { } }", "Sets")]
         [InlineData("public", "bool", "{ get; set; }", "Gets or sets a value indicating whether")]
         [InlineData("public", "bool", "{ get; }", "Gets a value indicating whether")]
+        [InlineData("public", "bool", "{ get; } = true;", "Gets a value indicating whether")]
+        [InlineData("public", "bool", "=> true;", "Gets a value indicating whether")]
         [InlineData("public", "bool", "{ get; private set; }", "Gets a value indicating whether")]
         [InlineData("public", "bool", "{ set { } }", "Sets a value indicating whether")]
         [InlineData("public", "bool", "{ private get { return false; } set { } }", "Sets a value indicating whether")]

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1624UnitTests.cs

@@ -77,6 +77,36 @@ public class TestClass
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Verifies that documentation that starts with the proper text for multiple accessors will not produce this
+        /// diagnostic when the property has an expression body.
+        /// </summary>
+        /// <param name="accessibility">The accessibility of the property.</param>
+        /// <param name="type">The type to use for the property.</param>
+        /// <param name="summaryPrefix">The prefix to use in the summary text.</param>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Theory]
+        [InlineData("public", "int", "Gets or sets")]
+        [InlineData("public", "bool", "Gets or sets a value indicating whether")]
+        [InlineData("protected", "int", "Gets or sets")]
+        [InlineData("protected internal", "int", "Gets or sets")]
+        [InlineData("internal", "int", "Gets or sets")]
+        public async Task VerifyThatInvalidDocumentationWillReportDiagnosticForExpressionBodyAsync(string accessibility, string type, string summaryPrefix)
+        {
+            var testCode = $@"
+public class TestClass
+{{
+    /// <summary>
+    /// {summaryPrefix} the test property.
+    /// </summary>
+    {accessibility} {type} TestProperty =>
+        default({type});
+}}
+";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         /// <summary>
         /// Verify that no diagnostic will be reported when a public and a private accessor are present within a property that is defined in a contained class of a private class.
         /// </summary>
@@ -109,6 +139,12 @@ public int TestProperty
             await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
+        /// <inheritdoc/>
+        protected override IEnumerable<string> GetDisabledDiagnostics()
+        {
+            yield return PropertySummaryDocumentationAnalyzer.SA1623Descriptor.Id;
+        }
+
         /// <inheritdoc/>
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {