Update SA1019 for nullable reference types

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp8/SpacingRules/SA1019CSharp8UnitTests.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
 // Licensed under the MIT License. See LICENSE in the project root for license information.
 
-#nullable disable
-
 namespace StyleCop.Analyzers.Test.CSharp8.SpacingRules
 {
     using System.Threading;
@@ -17,6 +15,76 @@ namespace StyleCop.Analyzers.Test.CSharp8.SpacingRules
 
     public partial class SA1019CSharp8UnitTests : SA1019CSharp7UnitTests
     {
+        [Fact]
+        [WorkItem(3006, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3006")]
+        public async Task TestNullForgivingOperatorWithMemberAccessAsync()
+        {
+            var testCode = @"#nullable enable
+
+class TestClass
+{
+    void Test(string? text)
+    {
+        _ = text!.Length;
+        _ = text! {|#0:.|}Length;
+        _ = text!{|#1:.|} Length;
+        _ = text! {|#2:?|}.ToString();
+        _ = text!?{|#3:.|} ToString();
+        _ = text! {|#4:?|}{|#5:.|} ToString();
+    }
+}
+";
+
+            var fixedCode = @"#nullable enable
+
+class TestClass
+{
+    void Test(string? text)
+    {
+        _ = text!.Length;
+        _ = text!.Length;
+        _ = text!.Length;
+        _ = text!?.ToString();
+        _ = text!?.ToString();
+        _ = text!?.ToString();
+    }
+}
+";
+
+            DiagnosticResult[] expected =
+            {
+                Diagnostic(DescriptorNotPreceded).WithArguments(".").WithLocation(0),
+                Diagnostic(DescriptorNotFollowed).WithArguments(".").WithLocation(1),
+                Diagnostic(DescriptorNotPreceded).WithArguments("?").WithLocation(2),
+                Diagnostic(DescriptorNotFollowed).WithArguments(".").WithLocation(3),
+                Diagnostic(DescriptorNotPreceded).WithArguments("?").WithLocation(4),
+                Diagnostic(DescriptorNotFollowed).WithArguments(".").WithLocation(5),
+            };
+
+            await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
+        }
+
+        [Fact]
+        [WorkItem(3006, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3006")]
+        public async Task TestNullForgivingOperatorWithMemberAccessNoDiagnosticsAsync()
+        {
+            const string testCode = @"#nullable enable
+
+class TestClass
+{
+    void Test(string? text)
+    {
+        _ = text!.Length;
+        _ = text!?.ToString();
+        _ = (text![0])!.ToString();
+        _ = (new TestClass()!).ToString();
+    }
+}
+";
+
+            await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         [Fact]
         [WorkItem(3052, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3052")]
         public async Task TestClosingSquareBracketFollowedByExclamationAsync()

documentation/SA1019.md

@@ -21,7 +21,7 @@ The spacing around a member access symbol is incorrect, within a C# code file.
 
 ## Rule description
 
-A violation of this rule occurs when the spacing around a member access symbol is incorrect. A member access symbol should not have whitespace on either side, unless it is the first character on the line.
+A violation of this rule occurs when the spacing around a member access symbol is incorrect. A member access symbol should not have whitespace on either side, unless it is the first character on the line. This includes member access that immediately follows the null-forgiving operator (`!`) introduced with nullable reference types in C# 8, such as `value!.Property` or `value!?.Method()`.
 
 ## How to fix violations