Fix IDE0034 ('default' expression can be simplified)

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1609SA1610CodeFixProvider.cs

@@ -174,7 +174,7 @@ private bool TryRemoveSummaryPrefix(ref SyntaxList<XmlNodeSyntax> summaryContent
             }
 
             // Find the token containing the prefix, such as "Gets or sets "
-            SyntaxToken prefixToken = default(SyntaxToken);
+            SyntaxToken prefixToken = default;
             foreach (SyntaxToken textToken in firstText.TextTokens)
             {
                 if (textToken.IsMissing)

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/ElementOrderCodeFixProvider.cs

@@ -113,7 +113,7 @@ private static SyntaxNode HandleNamespaceDeclaration(MemberOrderHelper memberOrd
         private static SyntaxNode OrderMember(MemberOrderHelper memberOrder, SyntaxList<MemberDeclarationSyntax> members, ImmutableArray<OrderingTrait> elementOrder, SyntaxNode syntaxRoot, IndentationSettings indentationSettings)
         {
             var memberIndex = members.IndexOf(memberOrder.Member);
-            MemberOrderHelper target = default(MemberOrderHelper);
+            MemberOrderHelper target = default;
 
             for (var i = memberIndex - 1; i >= 0; --i)
             {

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/OrderingRules/UsingCodeFixProvider.cs

@@ -480,7 +480,7 @@ public override SyntaxTrivia VisitTrivia(SyntaxTrivia trivia)
             {
                 if (this.fileHeader.Contains(trivia))
                 {
-                    return default(SyntaxTrivia);
+                    return default;
                 }
 
                 return base.VisitTrivia(trivia);

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/IndentationCodeFixProvider.cs

@@ -61,14 +61,14 @@ private static bool TryGetTextChange(Diagnostic diagnostic, SyntaxNode syntaxRoo
             string replacement;
             if (!diagnostic.Properties.TryGetValue(SA1137ElementsShouldHaveTheSameIndentation.ExpectedIndentationKey, out replacement))
             {
-                textChange = default(TextChange);
+                textChange = default;
                 return false;
             }
 
             var trivia = syntaxRoot.FindTrivia(diagnostic.Location.SourceSpan.Start);
 
             TextSpan originalSpan;
-            if (trivia == default(SyntaxTrivia))
+            if (trivia == default)
             {
                 // The warning was reported on a token because the line is not indented
                 originalSpan = new TextSpan(diagnostic.Location.SourceSpan.Start, 0);

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1120CodeFixProvider.cs

@@ -80,7 +80,7 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
             }
 
             // Replace all roots with an empty node
-            var newRoot = root.ReplaceTrivia(triviaToRemove, (original, rewritten) => default(SyntaxTrivia));
+            var newRoot = root.ReplaceTrivia(triviaToRemove, (original, rewritten) => default);
 
             Document updatedDocument = document.WithSyntaxRoot(newRoot);
             return updatedDocument;

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1130CodeFixProvider.cs

@@ -76,7 +76,7 @@ private static SyntaxNode ReplaceWithLambda(SemanticModel semanticModel, Anonymo
 
             if (parameterList == null)
             {
-                ImmutableArray<string> argumentList = default(ImmutableArray<string>);
+                ImmutableArray<string> argumentList = default;
 
                 switch (anonymousMethod.Parent.Kind())
                 {

StyleCop.Analyzers/StyleCop.Analyzers.Test/LightJson/JsonArrayTests.cs

@@ -26,7 +26,7 @@ public void TestConstructor()
             Assert.Equal(1, obj2[0].AsInteger);
             Assert.Equal("test2", obj2[1].AsString);
 
-            Assert.Throws<ArgumentNullException>("values", () => new JsonArray(default(JsonValue[])));
+            Assert.Throws<ArgumentNullException>("values", () => new JsonArray(default));
         }
 
         [Fact]

StyleCop.Analyzers/StyleCop.Analyzers.Test/LightJson/JsonValueTests.cs

@@ -308,7 +308,7 @@ public void TestConversionOperators()
         [Fact]
         public void TestOpInequality()
         {
-            Assert.False(JsonValue.Null != default(JsonValue));
+            Assert.False(JsonValue.Null != default);
             Assert.True(new JsonValue(true) != new JsonValue(0));
         }
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/Lightup/AutoWrapSeparatedSyntaxListTests.cs

@@ -11,7 +11,7 @@ public class AutoWrapSeparatedSyntaxListTests : SeparatedSyntaxListWrapperTestBa
     {
         internal override SeparatedSyntaxListWrapper<SyntaxNode> CreateList()
         {
-            return new SeparatedSyntaxListWrapper<SyntaxNode>.AutoWrapSeparatedSyntaxList<SyntaxNode>(default(SeparatedSyntaxList<SyntaxNode>));
+            return new SeparatedSyntaxListWrapper<SyntaxNode>.AutoWrapSeparatedSyntaxList<SyntaxNode>(default);
         }
 
         internal override bool TryCreateNonEmptyList(out SeparatedSyntaxListWrapper<SyntaxNode> list)

StyleCop.Analyzers/StyleCop.Analyzers.Test/Settings/SettingsUnitTests.cs

@@ -386,7 +386,7 @@ public AdditionalTextHelper(string path, string text)
 
             public override string Path { get; }
 
-            public override SourceText GetText(CancellationToken cancellationToken = default(CancellationToken))
+            public override SourceText GetText(CancellationToken cancellationToken = default)
             {
                 return this.sourceText;
             }