Updated PropertySummaryDocumentationAnalyzer to always report SA1623 for a property with a lone setter.

Author: bjornhellander

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1623UnitTests.cs

@@ -196,6 +196,8 @@ public int Property
         [InlineData("protected", "int", "=> 0;", "Gets or sets", "Gets")] // Regression test for #2253
         [InlineData("protected internal", "int", "=> 0;", "Gets or sets", "Gets")] // Regression test for #2253
         [InlineData("internal", "int", "=> 0;", "Gets or sets", "Gets")] // Regression test for #2253
+        [InlineData("public", "int", "{ set {} }", "Gets", "Sets")] // Regression test for #2253
+        [InlineData("public", "int", "{ set {} }", "Gets or sets", "Sets")] // Regression test for #2253
         public async Task IncorrectSummaryTagWithKnownPrefixShouldBeFixedCorrectlyAsync(string accessibility, string type, string accessors, string summaryPrefix, string expectedArgument)
         {
             var testCode = $@"

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PropertySummaryDocumentationAnalyzer.cs

@@ -282,16 +282,39 @@ private static void AnalyzeSummaryElement(SyntaxNodeAnalysisContext context, Xml
             }
             else if (setterVisible)
             {
-                if (startsWithGetsOrSets)
+                if (getter != null)
                 {
-                    diagnosticProperties.Add(ExpectedTextKey, startingTextSets);
-                    diagnosticProperties.Add(TextToRemoveKey, startingTextGetsOrSets);
-                    context.ReportDiagnostic(Diagnostic.Create(SA1624Descriptor, diagnosticLocation, diagnosticProperties.ToImmutable(), "set", startingTextSets));
+                    // Both getter and setter exist, but only setter is visible
+                    if (startsWithGetsOrSets)
+                    {
+                        diagnosticProperties.Add(ExpectedTextKey, startingTextSets);
+                        diagnosticProperties.Add(TextToRemoveKey, startingTextGetsOrSets);
+                        context.ReportDiagnostic(Diagnostic.Create(SA1624Descriptor, diagnosticLocation, diagnosticProperties.ToImmutable(), "set", startingTextSets));
+                    }
+                    else if (!startsWithSets)
+                    {
+                        diagnosticProperties.Add(ExpectedTextKey, startingTextSets);
+                        context.ReportDiagnostic(Diagnostic.Create(SA1623Descriptor, diagnosticLocation, diagnosticProperties.ToImmutable(), startingTextSets));
+                    }
                 }
-                else if (!startsWithSets)
+                else
                 {
-                    diagnosticProperties.Add(ExpectedTextKey, startingTextSets);
-                    context.ReportDiagnostic(Diagnostic.Create(SA1623Descriptor, diagnosticLocation, diagnosticProperties.ToImmutable(), startingTextSets));
+                    // Setter exists and is visible. Getter does not exist.
+                    if (!startsWithSets)
+                    {
+                        diagnosticProperties.Add(ExpectedTextKey, startingTextSets);
+
+                        if (startsWithGetsOrSets)
+                        {
+                            diagnosticProperties.Add(TextToRemoveKey, text.Substring(0, startingTextGetsOrSets.Length));
+                        }
+                        else if (startsWithGets)
+                        {
+                            diagnosticProperties.Add(TextToRemoveKey, text.Substring(0, startingTextGets.Length));
+                        }
+
+                        context.ReportDiagnostic(Diagnostic.Create(SA1623Descriptor, diagnosticLocation, diagnosticProperties.ToImmutable(), startingTextSets));
+                    }
                 }
             }
         }