Merge pull request #1593 from sharwell/fix-1590

Fix escaped quotes in XML attributes

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/XmlSyntaxFactoryTests.cs

@@ -17,7 +17,7 @@ public void TestPlainTextAttribute()
             Assert.Equal(" name=\"value\"", XmlSyntaxFactory.TextAttribute("name", "value").ToFullString());
         }
 
-        [Fact(Skip = "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/1590")]
+        [Fact]
         public void TestEscapedTextAttribute()
         {
             Assert.Equal(" name=\""value"\"", XmlSyntaxFactory.TextAttribute("name", "\"value\"").ToFullString());

StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlSyntaxFactory.cs

@@ -66,7 +66,7 @@ public static XmlTextSyntax Text(params SyntaxToken[] textTokens)
 
         public static XmlTextAttributeSyntax TextAttribute(string name, string value)
         {
-            return TextAttribute(name, TextLiteral(value));
+            return TextAttribute(name, TextLiteral(value, true));
         }
 
         public static XmlTextAttributeSyntax TextAttribute(string name, params SyntaxToken[] textTokens)
@@ -142,8 +142,18 @@ public static SyntaxToken TextNewLine(string text, bool continueComment)
         }
 
         public static SyntaxToken TextLiteral(string value)
+        {
+            return TextLiteral(value, false);
+        }
+
+        public static SyntaxToken TextLiteral(string value, bool escapeQuotes)
         {
             string encoded = new XText(value).ToString();
+            if (escapeQuotes)
+            {
+                encoded = encoded.Replace("\"", """);
+            }
+
             return SyntaxFactory.XmlTextLiteral(
                 SyntaxFactory.TriviaList(),
                 encoded,