Merge pull request #1784 from vweijsters/fix-1668

sharwell · sharwell · commit a16c309c7068 · 2015-11-18T14:31:31.000-06:00
Fixes null reference exception in SA1129
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1129DoNotUseDefaultValueTypeConstructor.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1129DoNotUseDefaultValueTypeConstructor.cs
@@ -51,7 +51,7 @@ private static void HandleObjectCreationExpression(SyntaxNodeAnalysisContext con
             ObjectCreationExpressionSyntax newExpression = (ObjectCreationExpressionSyntax)context.Node;
 
             var typeToCreate = context.SemanticModel.GetTypeInfo(newExpression, context.CancellationToken);
-            if (typeToCreate.Type.IsReferenceType || IsReferenceTypeParameter(typeToCreate.Type))
+            if ((typeToCreate.Type == null) || typeToCreate.Type.IsReferenceType || IsReferenceTypeParameter(typeToCreate.Type))
             {
                 return;
             }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ private static void HandleObjectCreationExpression(SyntaxNodeAnalysisContext con`
`51`	`51`	`ObjectCreationExpressionSyntax newExpression = (ObjectCreationExpressionSyntax)context.Node;`
`52`	`52`
`53`	`53`	`var typeToCreate = context.SemanticModel.GetTypeInfo(newExpression, context.CancellationToken);`
`54`		`- if (typeToCreate.Type.IsReferenceType \|\| IsReferenceTypeParameter(typeToCreate.Type))`
	`54`	`+ if ((typeToCreate.Type == null) \|\| typeToCreate.Type.IsReferenceType \|\| IsReferenceTypeParameter(typeToCreate.Type))`
`55`	`55`	`{`
`56`	`56`	`return;`
`57`	`57`	`}`