Merge pull request #3231 from sharwell/generate-lightup

Use code generation for IOperation in the light-up layer

Author: sharwell

StyleCop.Analyzers/Directory.Build.props

@@ -10,8 +10,8 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <LangVersion>8</LangVersion>
-    <Features>strict</Features>
+    <LangVersion>9</LangVersion>
+    <WarningLevel>5</WarningLevel>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(BuildingInsideVisualStudio)' != 'true'">
@@ -47,7 +47,12 @@
     <PackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.46" PrivateAssets="all" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.205" PrivateAssets="all" />
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.0" PrivateAssets="all" />
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="3.7.0-6.20427.1" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="3.8.0-5.final" PrivateAssets="all" />
+  </ItemGroup>
+
+  <!-- C# Compiler -->
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="3.8.0-5.final" PrivateAssets="all" />
   </ItemGroup>
 
   <!-- Public API -->

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/StyleCop.Analyzers.nuspec

@@ -37,7 +37,7 @@
     <file src="tools\uninstall.ps1" target="tools\" />
 
     <!-- Source code -->
-    <file src="..\StyleCop.Analyzers\**\*.cs" exclude="..\StyleCop.Analyzers\obj\**\*.cs" target="src"/>
+    <file src="..\StyleCop.Analyzers\**\*.cs" exclude="..\StyleCop.Analyzers\obj\**\*.cs;..\StyleCop.Analyzers\Lightup\.generated\**\*.cs" target="src"/>
     <file src="**\*.cs" exclude="obj\**\*.cs;Properties\AssemblyInfo.cs" target="src"/>
 
   </files>

StyleCop.Analyzers/StyleCop.Analyzers.CodeGeneration/OperationLightupGenerator.cs

@@ -0,0 +1,15 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+using System;
+using System.Runtime.InteropServices;
+
+// General Information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the information
+// associated with an assembly.
+[assembly: CLSCompliant(false)]
+
+// Setting ComVisible to false makes the types in this assembly not visible
+// to COM components.  If you need to access a type in this assembly from
+// COM, set the ComVisible attribute to true on that type.
+[assembly: ComVisible(false)]

StyleCop.Analyzers/StyleCop.Analyzers.CodeGeneration/Properties/AssemblyInfo.cs

@@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>netstandard2.0</TargetFrameworks>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <CodeAnalysisRuleSet>..\StyleCop.Analyzers.ruleset</CodeAnalysisRuleSet>
+  </PropertyGroup>
+
+  <PropertyGroup>
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>..\..\build\keys\StyleCopAnalyzers.snk</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.8.0-5.final" />
+  </ItemGroup>
+
+</Project>

StyleCop.Analyzers/StyleCop.Analyzers.CodeGeneration/PublicAPI.Shipped.txt

@@ -0,0 +1,83 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Test.CSharp7.Lightup
+{
+    using System.Collections.Generic;
+    using System.Reflection;
+    using Microsoft.CodeAnalysis;
+    using StyleCop.Analyzers.Lightup;
+    using Xunit;
+
+    public class OperationKindExTests
+    {
+        private static readonly Dictionary<OperationKind, string> OperationKindToName;
+        private static readonly Dictionary<string, OperationKind> NameToOperationKind;
+
+        static OperationKindExTests()
+        {
+            var renamedOperations =
+                new Dictionary<string, string>()
+                {
+                    { "BinaryOperator", "Binary" },
+                    { "ConstructorBodyOperation", "ConstructorBody" },
+                    { "MethodBodyOperation", "MethodBody" },
+                    { "TupleBinaryOperator", "TupleBinary" },
+                    { "UnaryOperator", "Unary" },
+                };
+
+            OperationKindToName = new Dictionary<OperationKind, string>();
+            NameToOperationKind = new Dictionary<string, OperationKind>();
+
+            foreach (var field in typeof(OperationKind).GetTypeInfo().DeclaredFields)
+            {
+                if (!field.IsStatic)
+                {
+                    continue;
+                }
+
+                var value = (OperationKind)field.GetRawConstantValue();
+                var name = field.Name;
+                if (renamedOperations.TryGetValue(name, out var newName))
+                {
+                    name = newName;
+                }
+
+                if (!OperationKindToName.ContainsKey(value))
+                {
+                    OperationKindToName[value] = name;
+                }
+
+                if (!NameToOperationKind.ContainsKey(name))
+                {
+                    NameToOperationKind.Add(name, value);
+                }
+            }
+        }
+
+        public static IEnumerable<object[]> OperationKinds
+        {
+            get
+            {
+                foreach (var field in typeof(OperationKindEx).GetTypeInfo().DeclaredFields)
+                {
+                    yield return new object[] { field.Name, (OperationKind)field.GetRawConstantValue() };
+                }
+            }
+        }
+
+        [Theory]
+        [MemberData(nameof(OperationKinds))]
+        public void TestOperationKind(string name, OperationKind operationKind)
+        {
+            if (OperationKindToName.TryGetValue(operationKind, out var expectedName))
+            {
+                Assert.Equal(expectedName, name);
+            }
+            else
+            {
+                Assert.False(NameToOperationKind.TryGetValue(name, out _));
+            }
+        }
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers.CodeGeneration/PublicAPI.Unshipped.txt

@@ -0,0 +1,11 @@
+// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
+// Licensed under the MIT License. See LICENSE in the project root for license information.
+
+namespace StyleCop.Analyzers.Test.CSharp8.Lightup
+{
+    using StyleCop.Analyzers.Test.CSharp7.Lightup;
+
+    public class OperationKindExTestsCSharp8 : OperationKindExTests
+    {
+    }
+}

StyleCop.Analyzers/StyleCop.Analyzers.CodeGeneration/StyleCop.Analyzers.CodeGeneration.csproj

@@ -8,9 +8,9 @@ namespace StyleCop.Analyzers.Test.CSharp9.DocumentationRules
 
     public class SA1600CSharp9UnitTests : SA1600CSharp8UnitTests
     {
-        protected override DiagnosticResult[] GetExpectedResultTestRegressionMethodGlobalNamespace(string code, int column)
+        protected override DiagnosticResult[] GetExpectedResultTestRegressionMethodGlobalNamespace(string code)
         {
-            if (code == "public void TestMember() { }" && column == 13)
+            if (code == "public void {|#0:TestMember|}() { }")
             {
                 return new[]
                 {
@@ -20,12 +20,12 @@ protected override DiagnosticResult[] GetExpectedResultTestRegressionMethodGloba
                     // /0/Test0.cs(4,1): error CS0106: The modifier 'public' is not valid for this item
                     DiagnosticResult.CompilerError("CS0106").WithSpan(4, 1, 4, 7).WithArguments("public"),
 
-                    // /0/Test0.cs(4,1): error CS8652: The feature 'top-level statements' is currently in Preview and *unsupported*. To use Preview features, use the 'preview' language version.
-                    DiagnosticResult.CompilerError("CS8652").WithSpan(4, 1, 4, 29).WithArguments("top-level statements"),
+                    // /0/Test0.cs(4,1): error CS8320: Feature 'top-level statements' is not available in C# 7.2. Please use language version 9.0 or greater.
+                    DiagnosticResult.CompilerError("CS8320").WithSpan(4, 1, 4, 29).WithArguments("top-level statements", "9.0"),
                 };
             }
 
-            return base.GetExpectedResultTestRegressionMethodGlobalNamespace(code, column);
+            return base.GetExpectedResultTestRegressionMethodGlobalNamespace(code);
         }
     }
 }