Addressed CR feedback

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1129UnitTests.cs

@@ -62,6 +62,7 @@ public void TestMethod()
         var v1 = new TestStruct(1);
         var v2 = new TestStruct(1) { TestProperty = 2 };
         var v3 = new TestStruct() { TestProperty = 2 };
+        var v4 = new TestStruct { TestProperty = 2 };
     }
 
     private struct TestStruct
@@ -183,6 +184,55 @@ private struct TestStruct
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Verifies that new expressions for value types through generics will generate diagnostics.
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        public async Task VerifyGenericsTypeCreationAsync()
+        {
+            var testCode = @"public class TestClass
+{
+    public T TestMethod1<T>()
+        where T : struct
+    {
+        return new T();
+    }
+
+    public T TestMethod2<T>()
+        where T : new()
+    {
+        return new T();
+    }
+}
+";
+
+            var fixedTestCode = @"public class TestClass
+{
+    public T TestMethod1<T>()
+        where T : struct
+    {
+        return default(T);
+    }
+
+    public T TestMethod2<T>()
+        where T : new()
+    {
+        return new T();
+    }
+}
+";
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation(6, 16)
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpDiagnosticAsync(fixedTestCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
+        }
+
         /// <inheritdoc/>
         protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()
         {

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1129CodeFixProvider.cs

@@ -33,7 +33,7 @@ public override FixAllProvider GetFixAllProvider()
 
         public override Task RegisterCodeFixesAsync(CodeFixContext context)
         {
-            foreach (var diagnostic in context.Diagnostics.Where(d => this.FixableDiagnosticIds.Contains(d.Id)))
+            foreach (var diagnostic in context.Diagnostics)
             {
                 context.RegisterCodeFix(
                     CodeAction.Create(

StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1129DoNotUseDefaultValueTypeConstructor.cs

@@ -3,6 +3,7 @@
 
 namespace StyleCop.Analyzers.ReadabilityRules
 {
+    using System;
     using System.Collections.Immutable;
     using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CSharp;
@@ -47,12 +48,12 @@ private static void HandleNewExpression(SyntaxNodeAnalysisContext context)
             ObjectCreationExpressionSyntax newExpression = (ObjectCreationExpressionSyntax)context.Node;
 
             var typeToCreate = context.SemanticModel.GetTypeInfo(newExpression, context.CancellationToken);
-            if (typeToCreate.Type.IsReferenceType)
+            if (typeToCreate.Type.IsReferenceType || IsReferenceTypeParameter(typeToCreate.Type))
             {
                 return;
             }
 
-            if (newExpression.ArgumentList.Arguments.Count > 0)
+            if ((newExpression.ArgumentList == null) || (newExpression.ArgumentList.Arguments.Count > 0))
             {
                 return;
             }
@@ -64,5 +65,10 @@ private static void HandleNewExpression(SyntaxNodeAnalysisContext context)
 
             context.ReportDiagnostic(Diagnostic.Create(Descriptor, newExpression.GetLocation()));
         }
+
+        private static bool IsReferenceTypeParameter(ITypeSymbol type)
+        {
+            return (type.Kind == SymbolKind.TypeParameter) && !((ITypeParameterSymbol)type).HasValueTypeConstraint;
+        }
     }
 }