Fix SA1127 hard-coding of CRLF

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1127CodeFixProvider.cs

@@ -56,6 +56,8 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
         private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)
         {
             var syntaxRoot = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
+            var sourceText = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);
+            var options = document.Project.Solution.Workspace.Options;
             var whereToken = syntaxRoot.FindToken(diagnostic.Location.SourceSpan.Start);
             var precedingToken = whereToken.GetPreviousToken();
             var endToken = syntaxRoot.FindToken(diagnostic.Location.SourceSpan.End);
@@ -65,11 +67,14 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
             var settings = SettingsHelper.GetStyleCopSettingsInCodeFix(document.Project.AnalyzerOptions, syntaxRoot.SyntaxTree, cancellationToken);
             var indentationTrivia = SyntaxFactory.Whitespace(parentIndentation + IndentationHelper.GenerateIndentationString(settings.Indentation, 1));
 
+            var precedingTokenEndOfLine = FormattingHelper.GetEndOfLineForCodeFix(precedingToken, sourceText, options);
+            var endTokenEndOfLine = FormattingHelper.GetEndOfLineForCodeFix(endToken, sourceText, options);
+
             var replaceMap = new Dictionary<SyntaxToken, SyntaxToken>()
             {
-                [precedingToken] = precedingToken.WithTrailingTrivia(SyntaxFactory.CarriageReturnLineFeed),
+                [precedingToken] = precedingToken.WithTrailingTrivia(precedingTokenEndOfLine),
                 [whereToken] = whereToken.WithLeadingTrivia(indentationTrivia),
-                [endToken] = endToken.WithTrailingTrivia(RemoveUnnecessaryWhitespaceTrivia(endToken).Add(SyntaxFactory.CarriageReturnLineFeed)),
+                [endToken] = endToken.WithTrailingTrivia(RemoveUnnecessaryWhitespaceTrivia(endToken).Add(endTokenEndOfLine)),
             };
 
             if (afterEndToken.IsKind(SyntaxKind.EqualsGreaterThanToken))

StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1127UnitTests.cs

@@ -9,6 +9,7 @@ namespace StyleCop.Analyzers.Test.ReadabilityRules
     using System.Threading;
     using System.Threading.Tasks;
     using Microsoft.CodeAnalysis.Testing;
+    using StyleCop.Analyzers.Test.Helpers;
     using Xunit;
     using static StyleCop.Analyzers.Test.Verifiers.StyleCopCodeFixVerifier<
         StyleCop.Analyzers.ReadabilityRules.SA1127GenericTypeConstraintsMustBeOnOwnLine,
@@ -49,22 +50,24 @@ public async Task TestViolationWithTypeDeclarationAsync(string declaration, stri
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }
 
-        [Fact]
-        public async Task TestViolationWithMethodDeclarationAsync()
+        [Theory]
+        [InlineData("\n")]
+        [InlineData("\r\n")]
+        public async Task TestViolationWithMethodDeclarationAsync(string lineEnding)
         {
             var testCode = $@"
 class Foo
 {{
-    private void Method<T>() where T : class {{ }}
-}}";
+    private void Method<T>() {{|#0:where T : class|}} {{ }}
+}}".ReplaceLineEndings(lineEnding);
             var fixedCode = $@"
 class Foo
 {{
     private void Method<T>()
         where T : class
     {{ }}
-}}";
-            var expected = Diagnostic().WithLocation(4, 30);
+}}".ReplaceLineEndings(lineEnding);
+            var expected = Diagnostic().WithLocation(0);
             await VerifyCSharpFixAsync(testCode, expected, fixedCode, CancellationToken.None).ConfigureAwait(false);
         }