Merge pull request #2442 from bjornhellander/Issue2440_LightJsonCulture

Update embedded LightJson to be culture agnostic

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/LightJson/JsonValueTests.cs

@@ -6,8 +6,10 @@ namespace StyleCop.Analyzers.Test.LightJson
     using System;
     using global::LightJson;
     using global::LightJson.Serialization;
+    using StyleCop.Analyzers.Test.Helpers;
     using Xunit;
 
+    [UseCulture("en-US")]
     public class JsonValueTests
     {
         [Fact]
@@ -106,18 +108,35 @@ public void TestAsNumber()
             Assert.Equal(0.0, new JsonValue(new JsonArray()).AsNumber);
         }
 
+        [Fact]
+        [WorkItem(2440, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2440")]
+        [UseCulture("sv-SE")]
+        public void TestAsNumbersUsingCultureWithNonStandardNumberFormat()
+        {
+            Assert.Equal(1.0, new JsonValue("1.0").AsNumber);
+        }
+
         [Fact]
         public void TestAsString()
         {
             Assert.Equal("false", new JsonValue(false).AsString);
             Assert.Equal("true", new JsonValue(true).AsString);
+            Assert.Equal("0.5", new JsonValue(0.5).AsString);
             Assert.Equal("1", new JsonValue(1.0).AsString);
             Assert.Equal("text", new JsonValue("text").AsString);
             Assert.Null(new JsonValue(new JsonObject()).AsString);
             Assert.Null(new JsonValue(default(JsonObject)).AsString);
             Assert.Null(new JsonValue(new JsonArray()).AsString);
         }
 
+        [Fact]
+        [WorkItem(2440, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2440")]
+        [UseCulture("sv-SE")]
+        public void TestAsStringUsingCultureWithNonStandardNumberFormat()
+        {
+            Assert.Equal("0.5", new JsonValue(0.5).AsString);
+        }
+
         [Fact]
         public void TestAsJsonObject()
         {

StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonValue.cs

@@ -7,6 +7,7 @@ namespace LightJson
     using System.Collections.Generic;
     using System.Diagnostics;
     using System.Diagnostics.CodeAnalysis;
+    using System.Globalization;
     using LightJson.Serialization;
 
     /// <summary>
@@ -332,7 +333,7 @@ public double AsNumber
 
                     case JsonValueType.String:
                         double number;
-                        if (double.TryParse((string)this.reference, out number))
+                        if (double.TryParse((string)this.reference, NumberStyles.Float, CultureInfo.InvariantCulture, out number))
                         {
                             return number;
                         }
@@ -363,7 +364,7 @@ public string AsString
                             : "false";
 
                     case JsonValueType.Number:
-                        return this.value.ToString();
+                        return this.value.ToString(CultureInfo.InvariantCulture);
 
                     case JsonValueType.String:
                         return (string)this.reference;