Update SA1019 to report violations for pointer member access

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1019UnitTests.cs

@@ -209,6 +209,14 @@ public unsafe void MethodName()
         x++ ?. ToString();
         x++ ?.ToString();
         x++?. ToString();
+
+        y-- -> ToString();
+        y-- ->ToString();
+        y---> ToString();
+
+        y++ -> ToString();
+        y++ ->ToString();
+        y++-> ToString();
     }
 }
 ";
@@ -234,6 +242,14 @@ public unsafe void MethodName()
         x++?.ToString();
         x++?.ToString();
         x++?.ToString();
+
+        y--->ToString();
+        y--->ToString();
+        y--->ToString();
+
+        y++->ToString();
+        y++->ToString();
+        y++->ToString();
     }
 }
 ";
@@ -258,6 +274,16 @@ public unsafe void MethodName()
                 this.CSharpDiagnostic().WithLocation(20, 14).WithArguments(".", "followed"),
                 this.CSharpDiagnostic().WithLocation(21, 13).WithArguments("?", "preceded"),
                 this.CSharpDiagnostic().WithLocation(22, 13).WithArguments(".", "followed"),
+
+                this.CSharpDiagnostic().WithLocation(24, 13).WithArguments("->", "preceded"),
+                this.CSharpDiagnostic().WithLocation(24, 13).WithArguments("->", "followed"),
+                this.CSharpDiagnostic().WithLocation(25, 13).WithArguments("->", "preceded"),
+                this.CSharpDiagnostic().WithLocation(26, 12).WithArguments("->", "followed"),
+
+                this.CSharpDiagnostic().WithLocation(28, 13).WithArguments("->", "preceded"),
+                this.CSharpDiagnostic().WithLocation(28, 13).WithArguments("->", "followed"),
+                this.CSharpDiagnostic().WithLocation(29, 13).WithArguments("->", "preceded"),
+                this.CSharpDiagnostic().WithLocation(30, 12).WithArguments("->", "followed"),
             };
 
             await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1019MemberAccessSymbolsMustBeSpacedCorrectly.cs

@@ -59,6 +59,10 @@ private static void HandleSyntaxTree(SyntaxTreeAnalysisContext context)
                     HandleDotToken(context, token);
                     break;
 
+                case SyntaxKind.MinusGreaterThanToken:
+                    HandleMemberAccessSymbol(context, token);
+                    break;
+
                 // This case handles the new ?. and ?[ operators
                 case SyntaxKind.QuestionToken:
                     HandleQuestionToken(context, token);