Use expected name for syntax node action method

sharwell · sharwell · commit bce43eaf46da · 2018-06-10T13:43:26.000-05:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1139UseLiteralSuffixNotationInsteadOfCasting.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1139UseLiteralSuffixNotationInsteadOfCasting.cs
@@ -31,7 +31,7 @@ internal class SA1139UseLiteralSuffixNotationInsteadOfCasting : DiagnosticAnalyz
 
         private static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.ReadabilityRules, DiagnosticSeverity.Warning, AnalyzerConstants.EnabledByDefault, Description, HelpLink);
         private static readonly Action<CompilationStartAnalysisContext> CompilationStartAction = HandleCompilationStart;
-        private static readonly Action<SyntaxNodeAnalysisContext> GenericNameAction = HandleGenericName;
+        private static readonly Action<SyntaxNodeAnalysisContext> CastExpressionAction = HandleCastExpression;
 
         /// <inheritdoc/>
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =
@@ -46,10 +46,10 @@ public override void Initialize(AnalysisContext context)
 
         private static void HandleCompilationStart(CompilationStartAnalysisContext context)
         {
-            context.RegisterSyntaxNodeAction(GenericNameAction, SyntaxKind.CastExpression);
+            context.RegisterSyntaxNodeAction(CastExpressionAction, SyntaxKind.CastExpression);
         }
 
-        private static void HandleGenericName(SyntaxNodeAnalysisContext context)
+        private static void HandleCastExpression(SyntaxNodeAnalysisContext context)
         {
             var castExpressionSyntax = (CastExpressionSyntax)context.Node;
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ internal class SA1139UseLiteralSuffixNotationInsteadOfCasting : DiagnosticAnalyz`
`31`	`31`
`32`	`32`	`private static readonly DiagnosticDescriptor Descriptor = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.ReadabilityRules, DiagnosticSeverity.Warning, AnalyzerConstants.EnabledByDefault, Description, HelpLink);`
`33`	`33`	`private static readonly Action<CompilationStartAnalysisContext> CompilationStartAction = HandleCompilationStart;`
`34`		`- private static readonly Action<SyntaxNodeAnalysisContext> GenericNameAction = HandleGenericName;`
	`34`	`+ private static readonly Action<SyntaxNodeAnalysisContext> CastExpressionAction = HandleCastExpression;`
`35`	`35`
`36`	`36`	`/// <inheritdoc/>`
`37`	`37`	`public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get; } =`
`@@ -46,10 +46,10 @@ public override void Initialize(AnalysisContext context)`
`46`	`46`
`47`	`47`	`private static void HandleCompilationStart(CompilationStartAnalysisContext context)`
`48`	`48`	`{`
`49`		`- context.RegisterSyntaxNodeAction(GenericNameAction, SyntaxKind.CastExpression);`
	`49`	`+ context.RegisterSyntaxNodeAction(CastExpressionAction, SyntaxKind.CastExpression);`
`50`	`50`	`}`
`51`	`51`
`52`		`- private static void HandleGenericName(SyntaxNodeAnalysisContext context)`
	`52`	`+ private static void HandleCastExpression(SyntaxNodeAnalysisContext context)`
`53`	`53`	`{`
`54`	`54`	`var castExpressionSyntax = (CastExpressionSyntax)context.Node;`
`55`	`55`