Treat empty XML elements as a "word not ending with a period"

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1629UnitTests.cs

@@ -377,6 +377,47 @@ public interface ITest
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        [Fact]
+        [WorkItem(2680, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2680")]
+        public async Task TestReportingAfterEmptyElementTwoSentencesAsync()
+        {
+            var testCode = @"
+/// <summary>
+/// Test interface. <see cref=""ITest""/>
+/// </summary>
+public interface ITest
+{
+    /// <summary>
+    /// Test method. <see cref=""Method""/><see cref=""Method""/>
+    /// </summary>
+    void Method();
+}
+";
+
+            var fixedTestCode = @"
+/// <summary>
+/// Test interface. <see cref=""ITest""/>.
+/// </summary>
+public interface ITest
+{
+    /// <summary>
+    /// Test method. <see cref=""Method""/><see cref=""Method""/>.
+    /// </summary>
+    void Method();
+}
+";
+
+            DiagnosticResult[] expected =
+            {
+                this.CSharpDiagnostic().WithLocation(3, 40),
+                this.CSharpDiagnostic().WithLocation(8, 62),
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpDiagnosticAsync(fixedTestCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
+        }
+
         [Fact]
         [WorkItem(2679, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2679")]
         public async Task TestElementsThatDoNotRequirePeriodsAsync()

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1629DocumentationTextMustEndWithAPeriod.cs

@@ -84,7 +84,6 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
                 }
 
                 var elementDone = false;
-                int? reportingLocation = null;
                 for (var i = xmlElement.Content.Count - 1; !elementDone && (i >= 0); i--)
                 {
                     if (xmlElement.Content[i] is XmlTextSyntax contentNode)
@@ -98,7 +97,7 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
                             {
                                 if (!textWithoutTrailingWhitespace.EndsWith(".", StringComparison.Ordinal))
                                 {
-                                    var location = Location.Create(xmlElement.SyntaxTree, new TextSpan(reportingLocation ?? textToken.SpanStart + textWithoutTrailingWhitespace.Length, 1));
+                                    var location = Location.Create(xmlElement.SyntaxTree, new TextSpan(textToken.SpanStart + textWithoutTrailingWhitespace.Length, 1));
                                     context.ReportDiagnostic(Diagnostic.Create(Descriptor, location));
                                 }
 
@@ -108,9 +107,10 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
                     }
                     else if (xmlElement.Content[i].IsInlineElement())
                     {
-                        // If a diagnostic gets reported for the element, place the diagnostic after the last inline
-                        // element.
-                        reportingLocation = reportingLocation ?? xmlElement.Content[i].Span.End;
+                        // Treat empty XML elements as a "word not ending with a period"
+                        var location = Location.Create(xmlElement.SyntaxTree, new TextSpan(xmlElement.Content[i].Span.End, 1));
+                        context.ReportDiagnostic(Diagnostic.Create(Descriptor, location));
+                        elementDone = true;
                     }
                 }
             }