Merge pull request #2007 from sharwell/port-1977

Port #1977 to stabilization

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1609UnitTests.cs

@@ -244,6 +244,43 @@ public class ClassName
             await this.VerifyCSharpFixAsync(testCode, fixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Regression test for DotNetAnalyzers/StyleCopAnalyzers#1942.
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        public async Task TestPropertyWithEmptySummaryAsync()
+        {
+            var testCode = @"
+public class ClassName
+{
+    /// <summary>
+    /// </summary>
+    public int Property
+    {
+        get;
+    }
+}";
+
+            var fixedCode = @"
+public class ClassName
+{
+    /// <summary>
+    /// </summary>
+    /// <value>
+    /// 
+    /// </value>
+    public int Property
+    {
+        get;
+    }
+}";
+
+            DiagnosticResult expected = this.CSharpDiagnostic().WithLocation(6, 16);
+            await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
+            await this.VerifyCSharpFixAsync(testCode, fixedCode, cancellationToken: CancellationToken.None).ConfigureAwait(false);
+        }
+
         protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()
         {
             yield return new SA1609PropertyDocumentationMustHaveValue();

StyleCop.Analyzers/StyleCop.Analyzers/Helpers/DocumentationCommentExtensions.cs

@@ -152,6 +152,11 @@ public static SyntaxList<XmlNodeSyntax> WithoutFirstAndLastNewlines(this SyntaxL
 
             for (int i = 0; i < removeFromEnd; i++)
             {
+                if (!lastSyntaxTokens.Any())
+                {
+                    break;
+                }
+
                 lastSyntaxTokens = lastSyntaxTokens.RemoveAt(lastSyntaxTokens.Count - 1);
             }