Avoid mutations if the result will match the input

sharwell · sharwell · commit c3ae121226c8 · 2016-01-13T05:08:09.000-06:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1137ElementsShouldHaveTheSameIndentation.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1137ElementsShouldHaveTheSameIndentation.cs
@@ -362,7 +362,7 @@ private static void CheckElements<T>(SyntaxNodeAnalysisContext context, Immutabl
             // Try to reorder the list so the first item is not an attribute list. This element will establish the
             // expected indentation for the entire collection.
             int desiredFirst = elements.FindIndex(x => !x.IsKind(SyntaxKind.AttributeList));
-            if (desiredFirst >= 0)
+            if (desiredFirst > 0)
             {
                 T newFirstElement = elements[desiredFirst];
                 elements = elements.RemoveAt(desiredFirst).Insert(0, newFirstElement);

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ private static void CheckElements<T>(SyntaxNodeAnalysisContext context, Immutabl`
`362`	`362`	`// Try to reorder the list so the first item is not an attribute list. This element will establish the`
`363`	`363`	`// expected indentation for the entire collection.`
`364`	`364`	`int desiredFirst = elements.FindIndex(x => !x.IsKind(SyntaxKind.AttributeList));`
`365`		`- if (desiredFirst >= 0)`
	`365`	`+ if (desiredFirst > 0)`
`366`	`366`	`{`
`367`	`367`	`T newFirstElement = elements[desiredFirst];`
`368`	`368`	`elements = elements.RemoveAt(desiredFirst).Insert(0, newFirstElement);`