Fix handling of alias-qualified System using directives in SA1208

sharwell · sharwell · commit c61bb3e61294 · 2015-12-03T20:17:26.000-06:00
Fixes #1818
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1208SystemUsingDirectivesMustBePlacedBeforeOtherUsingDirectives.cs b/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1208SystemUsingDirectivesMustBePlacedBeforeOtherUsingDirectives.cs
@@ -98,7 +98,7 @@ private static void ProcessUsingsAndReportDiagnostic(SyntaxList<UsingDirectiveSy
                     continue;
                 }
 
-                if (usingDirective.IsSystemUsingDirective())
+                if (usingDirective.IsSystemUsingDirective() && !usingDirective.HasNamespaceAliasQualifier())
                 {
                     if (systemUsingDirectivesShouldBeBeforeThisName != null)
                     {
@@ -108,7 +108,9 @@ private static void ProcessUsingsAndReportDiagnostic(SyntaxList<UsingDirectiveSy
 
                     var previousUsing = usings[i - 1];
 
-                    if (!previousUsing.IsSystemUsingDirective() || previousUsing.StaticKeyword.Kind() != SyntaxKind.None)
+                    if (!previousUsing.IsSystemUsingDirective()
+                        || previousUsing.HasNamespaceAliasQualifier()
+                        || previousUsing.StaticKeyword.Kind() != SyntaxKind.None)
                     {
                         systemUsingDirectivesShouldBeBeforeThisName = previousUsing.Name.ToNormalizedString();
                         context.ReportDiagnostic(Diagnostic.Create(Descriptor, usingDirective.GetLocation(), usingDirective.Name.ToNormalizedString(), systemUsingDirectivesShouldBeBeforeThisName));

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ private static void ProcessUsingsAndReportDiagnostic(SyntaxList<UsingDirectiveSy`
`98`	`98`	`continue;`
`99`	`99`	`}`
`100`	`100`
`101`		`- if (usingDirective.IsSystemUsingDirective())`
	`101`	`+ if (usingDirective.IsSystemUsingDirective() && !usingDirective.HasNamespaceAliasQualifier())`
`102`	`102`	`{`
`103`	`103`	`if (systemUsingDirectivesShouldBeBeforeThisName != null)`
`104`	`104`	`{`
`@@ -108,7 +108,9 @@ private static void ProcessUsingsAndReportDiagnostic(SyntaxList<UsingDirectiveSy`
`108`	`108`
`109`	`109`	`var previousUsing = usings[i - 1];`
`110`	`110`
`111`		`- if (!previousUsing.IsSystemUsingDirective() \|\| previousUsing.StaticKeyword.Kind() != SyntaxKind.None)`
	`111`	`+ if (!previousUsing.IsSystemUsingDirective()`
	`112`	`+ \|\| previousUsing.HasNamespaceAliasQualifier()`
	`113`	`+ \|\| previousUsing.StaticKeyword.Kind() != SyntaxKind.None)`
`112`	`114`	`{`
`113`	`115`	`systemUsingDirectivesShouldBeBeforeThisName = previousUsing.Name.ToNormalizedString();`
`114`	`116`	`context.ReportDiagnostic(Diagnostic.Create(Descriptor, usingDirective.GetLocation(), usingDirective.Name.ToNormalizedString(), systemUsingDirectivesShouldBeBeforeThisName));`