Merge pull request #3187 from NextTurn/target-typed-new

Update SA1000 for target-typed new expressions

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/SpacingRules/SA1000CSharp9UnitTests.cs

@@ -3,9 +3,20 @@
 
 namespace StyleCop.Analyzers.Test.CSharp9.SpacingRules
 {
+    using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis.CSharp;
+    using Microsoft.CodeAnalysis.Testing;
     using StyleCop.Analyzers.Test.CSharp8.SpacingRules;
+    using Xunit;
 
     public class SA1000CSharp9UnitTests : SA1000CSharp8UnitTests
     {
+        [Fact]
+        public async Task TestTargetTypedNewAsync()
+        {
+            string statementWithoutSpace = "int a = new();";
+
+            await this.TestKeywordStatementAsync(statementWithoutSpace, DiagnosticResult.EmptyDiagnosticResults, statementWithoutSpace, languageVersion: LanguageVersion.Preview).ConfigureAwait(false);
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers/Lightup/SyntaxKindEx.cs

@@ -18,6 +18,7 @@ internal static class SyntaxKindEx
         public const SyntaxKind ConflictMarkerTrivia = (SyntaxKind)8564;
         public const SyntaxKind IsPatternExpression = (SyntaxKind)8657;
         public const SyntaxKind RangeExpression = (SyntaxKind)8658;
+        public const SyntaxKind ImplicitObjectCreationExpression = (SyntaxKind)8659;
         public const SyntaxKind CoalesceAssignmentExpression = (SyntaxKind)8725;
         public const SyntaxKind IndexExpression = (SyntaxKind)8741;
         public const SyntaxKind DefaultLiteralExpression = (SyntaxKind)8755;

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1000KeywordsMustBeSpacedCorrectly.cs

@@ -293,7 +293,8 @@ private static void HandleNewOrStackAllocKeywordToken(ref SyntaxTreeAnalysisCont
 
             case SyntaxKind.OpenParenToken:
                 // Disallowed for new() constraint, but otherwise allowed for tuple types
-                needSpace = !token.Parent.IsKind(SyntaxKind.ConstructorConstraint);
+                needSpace = !token.Parent.IsKind(SyntaxKind.ConstructorConstraint)
+                    && !token.Parent.IsKind(SyntaxKindEx.ImplicitObjectCreationExpression);
                 break;
 
             default: