Fix SA1606 analyzer crashes with incomplete member

Noryoko · Noryoko · commit cf3793f87c3c · 2015-12-11T19:10:15.000-05:00
Fixes #1937
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationSummaryBase.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/ElementDocumentationSummaryBase.cs
@@ -233,7 +233,12 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, SyntaxNode nod
                 if (relevantXmlElement != null)
                 {
                     var declaration = context.SemanticModel.GetDeclaredSymbol(node, context.CancellationToken);
-                    var rawDocumentation = declaration?.GetDocumentationCommentXml(expandIncludes: true, cancellationToken: context.CancellationToken);
+                    if (declaration == null)
+                    {
+                        return;
+                    }
+
+                    var rawDocumentation = declaration.GetDocumentationCommentXml(expandIncludes: true, cancellationToken: context.CancellationToken);
                     completeDocumentation = XElement.Parse(rawDocumentation, LoadOptions.None);
                     if (completeDocumentation.Nodes().OfType<XElement>().Any(element => element.Name == XmlCommentHelper.InheritdocXmlTag))
                     {

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,12 @@ private void HandleDeclaration(SyntaxNodeAnalysisContext context, SyntaxNode nod`
`233`	`233`	`if (relevantXmlElement != null)`
`234`	`234`	`{`
`235`	`235`	`var declaration = context.SemanticModel.GetDeclaredSymbol(node, context.CancellationToken);`
`236`		`- var rawDocumentation = declaration?.GetDocumentationCommentXml(expandIncludes: true, cancellationToken: context.CancellationToken);`
	`236`	`+ if (declaration == null)`
	`237`	`+ {`
	`238`	`+ return;`
	`239`	`+ }`
	`240`	`+`
	`241`	`+ var rawDocumentation = declaration.GetDocumentationCommentXml(expandIncludes: true, cancellationToken: context.CancellationToken);`
`237`	`242`	`completeDocumentation = XElement.Parse(rawDocumentation, LoadOptions.None);`
`238`	`243`	`if (completeDocumentation.Nodes().OfType<XElement>().Any(element => element.Name == XmlCommentHelper.InheritdocXmlTag))`
`239`	`244`	`{`