Port pull request #1962 to stabilization

SA1303 should not report on enum members

(cherry picked from commit 633bafa)

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/NamingRules/SA1303UnitTests.cs

@@ -199,6 +199,24 @@ public async Task TestFieldWhichIsNotConstStartingWithLowerCaseAsync()
             await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Regression test for https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/1936.
+        /// </summary>
+        /// <remarks>SA1303 should not be reported on <c>enum</c> declarations. SA1300 will be reported in this case.</remarks>
+        /// <returns>A <see cref="Task"/> that represents the asynchronous operation.</returns>
+        [Fact]
+        public async Task TestEnumDeclarationsDoNotReportAsync()
+        {
+            var testCode = @"
+public enum SpecialFile
+{
+    iTunesMetadata
+}";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+
+        }
+
         protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()
         {
             yield return new SA1303ConstFieldNamesMustBeginWithUpperCaseLetter();

StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/SA1303ConstFieldNamesMustBeginWithUpperCaseLetter.cs

@@ -71,7 +71,7 @@ public void HandleFieldDeclaration(SymbolAnalysisContext context)
             {
                 var symbol = context.Symbol as IFieldSymbol;
 
-                if (symbol == null || !symbol.IsConst)
+                if (symbol == null || !symbol.IsConst || symbol.ContainingType?.TypeKind == TypeKind.Enum)
                 {
                     return;
                 }