Merge pull request #2833 from sharwell/formatting-analyzer

Enable formatting analyzer

Author: sharwell

StyleCop.Analyzers/Directory.Build.props

@@ -45,6 +45,7 @@
     <PackageReference Include="AsyncUsageAnalyzers" Version="1.0.0-alpha003" PrivateAssets="all" />
     <PackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.46" PrivateAssets="all" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.1-beta.61" PrivateAssets="all" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeStyle" Version="2.11.0-beta2-63603-03" PrivateAssets="all" />
   </ItemGroup>
 
   <ItemGroup>

StyleCop.Analyzers/StyleCop.Analyzers.ruleset

@@ -70,6 +70,9 @@
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Analyzers" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Analyzers">
     <Rule Id="RS1022" Action="None" /> <!-- https://github.com/dotnet/roslyn-analyzers/issues/1803 -->
   </Rules>
+  <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.CodeStyle" RuleNamespace="Microsoft.CodeAnalysis.CSharp.CodeStyle">
+    <Rule Id="IDE0055" Action="Warning" />
+  </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.Features" RuleNamespace="Microsoft.CodeAnalysis.CSharp.Features">
     <Rule Id="IDE0003" Action="None" />
   </Rules>

StyleCop.Analyzers/StyleCop.Analyzers/LightJson/JsonValue.cs

@@ -604,7 +604,9 @@ public static explicit operator int(JsonValue jsonValue)
         /// Throws System.InvalidCastException when the inner value type of the
         /// JsonValue is not the desired type of the conversion.
         /// </exception>
+#pragma warning disable IDE0055 // Fix formatting
         public static explicit operator int?(JsonValue jsonValue)
+#pragma warning restore IDE0055 // Fix formatting
         {
             if (jsonValue.IsNull)
             {
@@ -640,7 +642,9 @@ public static explicit operator bool(JsonValue jsonValue)
         /// Throws System.InvalidCastException when the inner value type of the
         /// JsonValue is not the desired type of the conversion.
         /// </exception>
+#pragma warning disable IDE0055 // Fix formatting
         public static explicit operator bool?(JsonValue jsonValue)
+#pragma warning restore IDE0055 // Fix formatting
         {
             if (jsonValue.IsNull)
             {
@@ -676,7 +680,9 @@ public static explicit operator double(JsonValue jsonValue)
         /// Throws System.InvalidCastException when the inner value type of the
         /// JsonValue is not the desired type of the conversion.
         /// </exception>
+#pragma warning disable IDE0055 // Fix formatting
         public static explicit operator double?(JsonValue jsonValue)
+#pragma warning restore IDE0055 // Fix formatting
         {
             if (jsonValue.IsNull)
             {
@@ -758,7 +764,9 @@ public static explicit operator DateTime(JsonValue jsonValue)
         /// Converts the given JsonValue into a nullable DateTime.
         /// </summary>
         /// <param name="jsonValue">The JsonValue to be converted.</param>
+#pragma warning disable IDE0055 // Fix formatting
         public static explicit operator DateTime?(JsonValue jsonValue)
+#pragma warning restore IDE0055 // Fix formatting
         {
             if (jsonValue.IsDateTime || jsonValue.IsNull)
             {