Added tests to improve coverage in SA1008 (OpeningParenthesisMustBeSpacedCorrectly)

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1008UnitTests.cs

@@ -6,6 +6,7 @@ namespace StyleCop.Analyzers.Test.SpacingRules
     using System.Collections.Generic;
     using System.Threading;
     using System.Threading.Tasks;
+    using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CodeFixes;
     using Microsoft.CodeAnalysis.Diagnostics;
     using StyleCop.Analyzers.SpacingRules;
@@ -1727,6 +1728,33 @@ public void TestMethod()
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        [Fact]
+        public async Task TestMissingTokenAsync()
+        {
+            string testCode = @"
+class ClassName
+{
+    ClassName()
+        : base)
+    {
+    }
+}
+";
+
+            DiagnosticResult[] expected =
+            {
+                new DiagnosticResult
+                {
+                    Id = "CS1003",
+                    Severity = DiagnosticSeverity.Error,
+                    Message = "Syntax error, '(' expected",
+                    Locations = new[] { new DiagnosticResultLocation("Test0.cs", 5, 15) }
+                }
+            };
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, expected, CancellationToken.None).ConfigureAwait(false);
+        }
+
         /// <inheritdoc/>
         protected override IEnumerable<DiagnosticAnalyzer> GetCSharpDiagnosticAnalyzers()
         {

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs

@@ -152,6 +152,7 @@ private static void HandleOpenParenToken(SyntaxTreeAnalysisContext context, Synt
             case SyntaxKind.DefaultExpression:
             case SyntaxKind.SizeOfExpression:
             case SyntaxKind.TypeOfExpression:
+            default:
                 haveLeadingSpace = false;
                 break;
 
@@ -182,10 +183,6 @@ private static void HandleOpenParenToken(SyntaxTreeAnalysisContext context, Synt
                 var partOfLambdaExpression = token.Parent.Parent.IsKind(SyntaxKind.ParenthesizedLambdaExpression);
                 haveLeadingSpace = partOfLambdaExpression;
                 break;
-
-            default:
-                haveLeadingSpace = false;
-                break;
             }
 
             // Ignore spacing before if another opening parenthesis is before this.