Improved SA1101 workaround to accept missing symbol information

vweijsters · vweijsters · commit d5e5bd72e25b · 2016-07-20T11:58:35.000+02:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1101PrefixLocalCallsWithThis.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1101PrefixLocalCallsWithThis.cs
@@ -193,8 +193,11 @@ private static void HandleIdentifierNameImpl(SyntaxNodeAnalysisContext context,
                 {
                     var memberAccessSymbol = context.SemanticModel.GetSymbolInfo(nameExpression.Parent, context.CancellationToken).Symbol;
 
-                    switch (memberAccessSymbol.Kind)
+                    switch (memberAccessSymbol?.Kind)
                     {
+                        case null:
+                            break;
+
                         case SymbolKind.Field:
                         case SymbolKind.Method:
                         case SymbolKind.Property:

Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,11 @@ private static void HandleIdentifierNameImpl(SyntaxNodeAnalysisContext context,`
`193`	`193`	`{`
`194`	`194`	`var memberAccessSymbol = context.SemanticModel.GetSymbolInfo(nameExpression.Parent, context.CancellationToken).Symbol;`
`195`	`195`
`196`		`- switch (memberAccessSymbol.Kind)`
	`196`	`+ switch (memberAccessSymbol?.Kind)`
`197`	`197`	`{`
	`198`	`+ case null:`
	`199`	`+ break;`
	`200`	`+`
`198`	`201`	`case SymbolKind.Field:`
`199`	`202`	`case SymbolKind.Method:`
`200`	`203`	`case SymbolKind.Property:`