Skip to content

Commit d625c19

Browse files
committed
Added operator and destructor support to SA1648
1 parent 950cc79 commit d625c19

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1648UnitTests.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,9 @@ public async Task TestTypeWithEmptyBaseListAsync(string declaration)
8181
[InlineData("string this [string f] { get { return f; } }")]
8282
[InlineData("event System.Action foo;")]
8383
[InlineData("event System.Action Foo { add { } remove { } }")]
84+
[InlineData("~Test() { }")]
85+
[InlineData("public static Test operator +(Test value) { return value; }")]
86+
[InlineData("public static explicit operator Test(int value) { return new Test(); }")]
8487
public async Task TestMemberThatShouldNotHaveInheritDocAsync(string declaration)
8588
{
8689
var testCode = @"class Test

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1648InheritDocMustBeUsedWithInheritingClass.cs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,17 @@ internal class SA1648InheritDocMustBeUsedWithInheritingClass : DiagnosticAnalyze
4141
ImmutableArray.Create(SyntaxKind.ClassDeclaration, SyntaxKind.StructDeclaration, SyntaxKind.InterfaceDeclaration, SyntaxKind.EnumDeclaration, SyntaxKind.DelegateDeclaration);
4242

4343
private static readonly ImmutableArray<SyntaxKind> MemberDeclarationKinds =
44-
ImmutableArray.Create(SyntaxKind.ConstructorDeclaration, SyntaxKind.EventDeclaration, SyntaxKind.MethodDeclaration, SyntaxKind.PropertyDeclaration, SyntaxKind.EventFieldDeclaration, SyntaxKind.FieldDeclaration, SyntaxKind.IndexerDeclaration);
44+
ImmutableArray.Create(
45+
SyntaxKind.ConstructorDeclaration,
46+
SyntaxKind.DestructorDeclaration,
47+
SyntaxKind.EventDeclaration,
48+
SyntaxKind.MethodDeclaration,
49+
SyntaxKind.PropertyDeclaration,
50+
SyntaxKind.EventFieldDeclaration,
51+
SyntaxKind.FieldDeclaration,
52+
SyntaxKind.IndexerDeclaration,
53+
SyntaxKind.OperatorDeclaration,
54+
SyntaxKind.ConversionOperatorDeclaration);
4555

4656
private static readonly Action<CompilationStartAnalysisContext> CompilationStartAction = HandleCompilationStart;
4757
private static readonly Action<SyntaxNodeAnalysisContext> BaseTypeLikeDeclarationAction = HandleBaseTypeLikeDeclaration;

0 commit comments

Comments
 (0)