Skip to content

Commit e0676f5

Browse files
committed
Merge pull request #1631 from vweijsters/codefix-cleanup-registercodefix
Reformatted all RegisterCodeFix calls
2 parents db9d252 + 2482bf1 commit e0676f5

72 files changed

Lines changed: 382 additions & 76 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.Designer.cs

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/DocumentationResources.resx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,9 @@
123123
<data name="SA1609SA1610CodeFix" xml:space="preserve">
124124
<value>Document value from summary</value>
125125
</data>
126+
<data name="SA1615SA1616CodeFix" xml:space="preserve">
127+
<value>Document return value</value>
128+
</data>
126129
<data name="SA1617CodeFix" xml:space="preserve">
127130
<value>Remove &lt;returns&gt; XML comment</value>
128131
</data>

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/FileHeaderCodeFixProvider.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
5252
{
5353
foreach (Diagnostic diagnostic in context.Diagnostics)
5454
{
55-
context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1633CodeFix, token => GetTransformedDocumentAsync(context.Document, token), equivalenceKey: nameof(FileHeaderCodeFixProvider)), diagnostic);
55+
context.RegisterCodeFix(
56+
CodeAction.Create(
57+
DocumentationResources.SA1633CodeFix,
58+
cancellationToken => GetTransformedDocumentAsync(context.Document, cancellationToken),
59+
nameof(FileHeaderCodeFixProvider)),
60+
diagnostic);
5661
}
5762

5863
return SpecializedTasks.CompletedTask;

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1609SA1610CodeFixProvider.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
4545
{
4646
foreach (var diagnostic in context.Diagnostics)
4747
{
48-
string description = DocumentationResources.SA1609SA1610CodeFix;
49-
context.RegisterCodeFix(CodeAction.Create(description, cancellationToken => this.GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken), equivalenceKey: nameof(SA1609SA1610CodeFixProvider)), diagnostic);
48+
context.RegisterCodeFix(
49+
CodeAction.Create(
50+
DocumentationResources.SA1609SA1610CodeFix,
51+
cancellationToken => this.GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken),
52+
nameof(SA1609SA1610CodeFixProvider)),
53+
diagnostic);
5054
}
5155

5256
return SpecializedTasks.CompletedTask;

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1615SA1616CodeFixProvider.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
4545
{
4646
foreach (var diagnostic in context.Diagnostics)
4747
{
48-
string description = "Document return value";
49-
context.RegisterCodeFix(CodeAction.Create(description, cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken), equivalenceKey: nameof(SA1615SA1616CodeFixProvider)), diagnostic);
48+
context.RegisterCodeFix(
49+
CodeAction.Create(
50+
DocumentationResources.SA1615SA1616CodeFix,
51+
cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken),
52+
nameof(SA1615SA1616CodeFixProvider)),
53+
diagnostic);
5054
}
5155

5256
return SpecializedTasks.CompletedTask;

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1617CodeFixProvider.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
4040
{
4141
foreach (Diagnostic diagnostic in context.Diagnostics)
4242
{
43-
context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1617CodeFix, token => GetTransformedDocumentAsync(context.Document, diagnostic, token), equivalenceKey: nameof(SA1617CodeFixProvider)), diagnostic);
43+
context.RegisterCodeFix(
44+
CodeAction.Create(
45+
DocumentationResources.SA1617CodeFix,
46+
cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken),
47+
nameof(SA1617CodeFixProvider)),
48+
diagnostic);
4449
}
4550

4651
return SpecializedTasks.CompletedTask;

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1626CodeFixProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
4444
CodeAction.Create(
4545
DocumentationResources.SA1626CodeFix,
4646
cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken),
47-
equivalenceKey: nameof(SA1626CodeFixProvider)),
47+
nameof(SA1626CodeFixProvider)),
4848
diagnostic);
4949
}
5050

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642SA1643CodeFixProvider.cs

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,22 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
5555

5656
if (xmlElementSyntax != null)
5757
{
58-
context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1642SA1643CodeFix, token => GetTransformedDocumentAsync(context.Document, root, xmlElementSyntax), equivalenceKey: nameof(SA1642SA1643CodeFixProvider)), diagnostic);
58+
context.RegisterCodeFix(
59+
CodeAction.Create(
60+
DocumentationResources.SA1642SA1643CodeFix,
61+
cancellationToken => GetTransformedDocumentAsync(context.Document, root, xmlElementSyntax),
62+
nameof(SA1642SA1643CodeFixProvider)),
63+
diagnostic);
5964
}
6065
else
6166
{
6267
var xmlEmptyElementSyntax = (XmlEmptyElementSyntax)node;
63-
context.RegisterCodeFix(CodeAction.Create(DocumentationResources.SA1642SA1643CodeFix, token => GetTransformedDocumentAsync(context.Document, root, xmlEmptyElementSyntax), equivalenceKey: nameof(SA1642SA1643CodeFixProvider)), diagnostic);
68+
context.RegisterCodeFix(
69+
CodeAction.Create(
70+
DocumentationResources.SA1642SA1643CodeFix,
71+
cancellationToken => GetTransformedDocumentAsync(context.Document, root, xmlEmptyElementSyntax),
72+
nameof(SA1642SA1643CodeFixProvider)),
73+
diagnostic);
6474
}
6575
}
6676
}

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1651CodeFixProvider.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,12 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
6161
continue;
6262
}
6363

64-
string description = DocumentationResources.SA1651CodeFix;
65-
context.RegisterCodeFix(CodeAction.Create(description, cancellationToken => this.GetTransformedDocumentAsync(context.Document, xmlElementSyntax, cancellationToken), equivalenceKey: nameof(SA1651CodeFixProvider)), diagnostic);
64+
context.RegisterCodeFix(
65+
CodeAction.Create(
66+
DocumentationResources.SA1651CodeFix,
67+
cancellationToken => this.GetTransformedDocumentAsync(context.Document, xmlElementSyntax, cancellationToken),
68+
nameof(SA1651CodeFixProvider)),
69+
diagnostic);
6670
}
6771
}
6872

StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1500CodeFixProvider.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,12 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
4040
{
4141
foreach (Diagnostic diagnostic in context.Diagnostics)
4242
{
43-
context.RegisterCodeFix(CodeAction.Create(LayoutResources.SA1500CodeFix, token => GetTransformedDocumentAsync(context.Document, diagnostic, token), equivalenceKey: nameof(SA1500CodeFixProvider)), diagnostic);
43+
context.RegisterCodeFix(
44+
CodeAction.Create(
45+
LayoutResources.SA1500CodeFix,
46+
cancellationToken => GetTransformedDocumentAsync(context.Document, diagnostic, cancellationToken),
47+
nameof(SA1500CodeFixProvider)),
48+
diagnostic);
4449
}
4550

4651
return SpecializedTasks.CompletedTask;

0 commit comments

Comments
 (0)