Update SA1403 for file-scoped namespaces

sharwell · sharwell · commit e16de1d1f4b1 · 2022-01-27T21:18:29.000-08:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1403FileMayOnlyContainASingleNamespace.cs b/StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1403FileMayOnlyContainASingleNamespace.cs
@@ -51,7 +51,8 @@ private static void HandleSyntaxTree(SyntaxTreeAnalysisContext context)
         {
             var syntaxRoot = context.Tree.GetRoot(context.CancellationToken);
 
-            var descentNodes = syntaxRoot.DescendantNodes(descendIntoChildren: node => node != null && !node.IsKind(SyntaxKind.ClassDeclaration));
+            // No need to check file-scoped namespaces because the compiler only allows one per file
+            var descentNodes = syntaxRoot.DescendantNodes(descendIntoChildren: node => node.IsKind(SyntaxKind.CompilationUnit) || node.IsKind(SyntaxKind.NamespaceDeclaration));
 
             bool foundNode = false;
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ private static void HandleSyntaxTree(SyntaxTreeAnalysisContext context)`
`51`	`51`	`{`
`52`	`52`	`var syntaxRoot = context.Tree.GetRoot(context.CancellationToken);`
`53`	`53`
`54`		`- var descentNodes = syntaxRoot.DescendantNodes(descendIntoChildren: node => node != null && !node.IsKind(SyntaxKind.ClassDeclaration));`
	`54`	`+ // No need to check file-scoped namespaces because the compiler only allows one per file`
	`55`	`+ var descentNodes = syntaxRoot.DescendantNodes(descendIntoChildren: node => node.IsKind(SyntaxKind.CompilationUnit) \|\| node.IsKind(SyntaxKind.NamespaceDeclaration));`
`55`	`56`
`56`	`57`	`bool foundNode = false;`
`57`	`58`