Skip to content

Commit e5ce272

Browse files
committed
Fix the "Turkish İ" problem
The following tests fail on a platform having Turkish specific settings: * SA1300UnitTests.TestLowerCaseInterfaceMembersAsync * SA1312UnitTests.TestRenameConflictsWithKeywordAsync * SA1313UnitTests.TestRenameConflictsWithKeywordAsync That's bacause upper(i) gives "İ" and lower(I) gives "ı" in Turkish. (More info: https://haacked.com/archive/2012/07/05/turkish-i-problem-and-why-you-should-care.aspx/) This fix adds UseCulture attribute to those problematic classes.
1 parent 663b52a commit e5ce272

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers.Test/NamingRules/SA1300UnitTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ namespace StyleCop.Analyzers.Test.NamingRules
99
using Microsoft.CodeAnalysis.CodeFixes;
1010
using Microsoft.CodeAnalysis.Diagnostics;
1111
using StyleCop.Analyzers.NamingRules;
12+
using StyleCop.Analyzers.Test.Helpers;
1213
using TestHelper;
1314
using Xunit;
1415

16+
[UseCulture("en-US")]
1517
public class SA1300UnitTests : CodeFixVerifier
1618
{
1719
[Fact]

StyleCop.Analyzers/StyleCop.Analyzers.Test/NamingRules/SA1312UnitTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ namespace StyleCop.Analyzers.Test.NamingRules
99
using Microsoft.CodeAnalysis.CodeFixes;
1010
using Microsoft.CodeAnalysis.Diagnostics;
1111
using StyleCop.Analyzers.NamingRules;
12+
using StyleCop.Analyzers.Test.Helpers;
1213
using TestHelper;
1314
using Xunit;
1415

16+
[UseCulture("en-US")]
1517
public class SA1312UnitTests : CodeFixVerifier
1618
{
1719
[Fact]

StyleCop.Analyzers/StyleCop.Analyzers.Test/NamingRules/SA1313UnitTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ namespace StyleCop.Analyzers.Test.NamingRules
99
using Microsoft.CodeAnalysis.CodeFixes;
1010
using Microsoft.CodeAnalysis.Diagnostics;
1111
using StyleCop.Analyzers.NamingRules;
12+
using StyleCop.Analyzers.Test.Helpers;
1213
using TestHelper;
1314
using Xunit;
1415

16+
[UseCulture("en-US")]
1517
public class SA1313UnitTests : CodeFixVerifier
1618
{
1719
[Fact]

0 commit comments

Comments
 (0)