Remove unnecessary handling of null location in SA1612

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1612ElementParameterDocumentationMustMatchElementParameters.cs

@@ -68,7 +68,6 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
                 return;
             }
 
-            var identifierLocation = identifier.Value.GetLocation();
             var parameterList = GetParameters(node)?.ToImmutableArray();
 
             bool hasNoParameters = !parameterList?.Any() ?? false;
@@ -84,18 +83,19 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
             {
                 var nameAttributeSyntax = XmlCommentHelper.GetFirstAttributeOrDefault<XmlNameAttributeSyntax>(syntax);
                 var nameAttributeText = nameAttributeSyntax?.Identifier?.Identifier.ValueText;
-                var location = nameAttributeSyntax?.Identifier?.Identifier.GetLocation();
 
                 // Make sure we ignore violations that should be reported by SA1613 instead.
                 if (string.IsNullOrWhiteSpace(nameAttributeText))
                 {
                     return;
                 }
 
+                var location = nameAttributeSyntax.Identifier.Identifier.GetLocation();
+
                 var parentParameter = parentParameters.FirstOrDefault(s => s.Identifier.ValueText == nameAttributeText);
                 if (parentParameter == null)
                 {
-                    context.ReportDiagnostic(Diagnostic.Create(MissingParameterDescriptor, location ?? identifierLocation, nameAttributeText));
+                    context.ReportDiagnostic(Diagnostic.Create(MissingParameterDescriptor, location, nameAttributeText));
                 }
                 else
                 {
@@ -114,7 +114,7 @@ protected override void HandleXmlElement(SyntaxNodeAnalysisContext context, bool
                         context.ReportDiagnostic(
                             Diagnostic.Create(
                                 OrderDescriptor,
-                                location ?? identifierLocation,
+                                location,
                                 nameAttributeText,
                                 parentParameters.IndexOf(parentParameter) + 1));
                     }