Improve code coverage, makes question on NotImplementedException obsolete

lukas-ais · lukas-ais · commit e86f75f6ca9a · 2016-02-23T18:32:14.000+01:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PropertySummaryDocumentationAnalyzer.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PropertySummaryDocumentationAnalyzer.cs
@@ -203,16 +203,10 @@ private static void AnalyzeSummaryElement(SyntaxNodeAnalysisContext context, Xml
                     getterVisible = true;
                     setterVisible = false;
                 }
-                else if (setter != null)
-                {
-                    getterVisible = false;
-                    setterVisible = true;
-                }
                 else
                 {
-                    // TODO Raise a NotImplementedException?
                     getterVisible = false;
-                    setterVisible = false;
+                    setterVisible = setter != null;
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -203,16 +203,10 @@ private static void AnalyzeSummaryElement(SyntaxNodeAnalysisContext context, Xml`
`203`	`203`	`getterVisible = true;`
`204`	`204`	`setterVisible = false;`
`205`	`205`	`}`
`206`		`- else if (setter != null)`
`207`		`- {`
`208`		`- getterVisible = false;`
`209`		`- setterVisible = true;`
`210`		`- }`
`211`	`206`	`else`
`212`	`207`	`{`
`213`		`- // TODO Raise a NotImplementedException?`
`214`	`208`	`getterVisible = false;`
`215`		`- setterVisible = false;`
	`209`	`+ setterVisible = setter != null;`
`216`	`210`	`}`
`217`	`211`	`}`
`218`	`212`