Update SA1612 for partial methods

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp9/DocumentationRules/SA1612CSharp9UnitTests.cs

@@ -3,9 +3,36 @@
 
 namespace StyleCop.Analyzers.Test.CSharp9.DocumentationRules
 {
+    using System.Threading;
+    using System.Threading.Tasks;
     using StyleCop.Analyzers.Test.CSharp8.DocumentationRules;
+    using Xunit;
+    using static StyleCop.Analyzers.Test.Verifiers.CustomDiagnosticVerifier<StyleCop.Analyzers.DocumentationRules.SA1612ElementParameterDocumentationMustMatchElementParameters>;
 
     public partial class SA1612CSharp9UnitTests : SA1612CSharp8UnitTests
     {
+        [Fact]
+        [WorkItem(3971, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3971")]
+        public async Task TestPartialMethodDeclarationWithMismatchedParameterDocumentationAsync()
+        {
+            var testCode = @"
+/// <summary>
+/// Tests a partial method.
+/// </summary>
+public partial class TestClass
+{
+    /// <summary>Declaration.</summary>
+    /// <param name=""{|#0:value|}"">Value.</param>
+    public partial void TestMethod(int other);
+
+    public partial void TestMethod(int other)
+    {
+    }
+}";
+
+            var expected = Diagnostic().WithLocation(0).WithArguments("value");
+
+            await VerifyCSharpDiagnosticAsync(testCode, new[] { expected }, CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1612UnitTests.cs

@@ -562,35 +562,15 @@ public class ClassName
             await VerifyCSharpDiagnosticAsync(testCode, DiagnosticResult.EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
-        private static DiagnosticResult[] GetExpectedDiagnostics(DiagnosticResult normallyExpected, string declaration)
-        {
-            return GetExpectedDiagnostics(new[] { normallyExpected }, declaration);
-        }
-
         // Syntax node actions for type declarations with a primary constructor were called twice
         // before support for c# 11 was added.
-        private static DiagnosticResult[] GetExpectedDiagnostics(DiagnosticResult[] normallyExpected, string declaration)
-        {
-            var isPrimaryConstructor = declaration.Contains("record") || declaration.Contains("class") || declaration.Contains("struct");
-
-            if (isPrimaryConstructor && !LightupHelpers.SupportsCSharp11)
-            {
-                // Diagnostic issued twice because of https://github.com/dotnet/roslyn/issues/53136 and https://github.com/dotnet/roslyn/issues/70488
-                return normallyExpected.Concat(normallyExpected).ToArray();
-            }
-            else
-            {
-                return normallyExpected;
-            }
-        }
-
-        private static Task VerifyCSharpDiagnosticAsync(string source, DiagnosticResult[] expected, CancellationToken cancellationToken)
+        protected static Task VerifyCSharpDiagnosticAsync(string source, DiagnosticResult[] expected, CancellationToken cancellationToken)
             => VerifyCSharpDiagnosticAsync(source, testSettings: null, expected, ignoreCompilerDiagnostics: false, cancellationToken);
 
-        private static Task VerifyCSharpDiagnosticAsync(string source, string testSettings, DiagnosticResult[] expected, CancellationToken cancellationToken)
+        protected static Task VerifyCSharpDiagnosticAsync(string source, string testSettings, DiagnosticResult[] expected, CancellationToken cancellationToken)
             => VerifyCSharpDiagnosticAsync(source, testSettings, expected, ignoreCompilerDiagnostics: false, cancellationToken);
 
-        private static Task VerifyCSharpDiagnosticAsync(string source, string testSettings, DiagnosticResult[] expected, bool ignoreCompilerDiagnostics, CancellationToken cancellationToken)
+        protected static Task VerifyCSharpDiagnosticAsync(string source, string testSettings, DiagnosticResult[] expected, bool ignoreCompilerDiagnostics, CancellationToken cancellationToken)
         {
             string contentWithoutParamDocumentation = @"<?xml version=""1.0"" encoding=""utf-8"" ?>
 <ClassName>
@@ -696,5 +676,23 @@ private static Task VerifyCSharpDiagnosticAsync(string source, string testSettin
             test.ExpectedDiagnostics.AddRange(expected);
             return test.RunAsync(cancellationToken);
         }
+
+        private static DiagnosticResult[] GetExpectedDiagnostics(DiagnosticResult normallyExpected, string declaration)
+        {
+            return GetExpectedDiagnostics(new[] { normallyExpected }, declaration);
+        }
+
+        private static DiagnosticResult[] GetExpectedDiagnostics(DiagnosticResult[] normallyExpected, string declaration)
+        {
+            var isPrimaryConstructor = declaration.Contains("record") || declaration.Contains("class") || declaration.Contains("struct");
+
+            if (isPrimaryConstructor && !LightupHelpers.SupportsCSharp11)
+            {
+                // Diagnostic issued twice because of https://github.com/dotnet/roslyn/issues/53136 and https://github.com/dotnet/roslyn/issues/70488
+                return normallyExpected.Concat(normallyExpected).ToArray();
+            }
+
+            return normallyExpected;
+        }
     }
 }