Make SA1008 fix do not remove new line

Author: pantosha

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/SpacingRules/TokenSpacingCodeFixProvider.cs

@@ -239,9 +239,10 @@ private static void UpdateReplaceMap(Dictionary<SyntaxToken, SyntaxToken> replac
 
                 case TokenSpacingProperties.ActionRemove:
                     triviaList = token.TrailingTrivia.AddRange(nextToken.LeadingTrivia);
+                    bool preserveLayout = layout == TokenSpacingProperties.LayoutPreserve;
 
                     UpdateReplaceMap(replaceMap, token, t => t.WithTrailingTrivia());
-                    UpdateReplaceMap(replaceMap, nextToken, t => t.WithLeadingTrivia(triviaList.WithoutLeadingWhitespace(true)));
+                    UpdateReplaceMap(replaceMap, nextToken, t => t.WithLeadingTrivia(triviaList.WithoutLeadingWhitespace(endOfLineIsWhitespace: !preserveLayout)));
                     break;
                 }
 

StyleCop.Analyzers/StyleCop.Analyzers.Test/SpacingRules/SA1008UnitTests.cs

@@ -144,6 +144,14 @@ public void TestMethod2 (
             int z)
         {
         }
+
+        // Opening parenthesis followed by space
+        public void TestMethod3( 
+            int x,
+            int y,
+            int z)
+        {
+        }
     }
 }
 ";
@@ -165,13 +173,22 @@ public void TestMethod2(
             int z)
         {
         }
+
+        // Opening parenthesis followed by space
+        public void TestMethod3(
+            int x,
+            int y,
+            int z)
+        {
+        }
     }
 }
 ";
 
             DiagnosticResult[] expectedDiagnostics =
             {
                 Diagnostic(DescriptorNotPreceded).WithLocation(12, 33),
+                Diagnostic(DescriptorNotFollowed).WithLocation(20, 32),
             };
 
             await VerifyCSharpFixAsync(testCode, expectedDiagnostics, fixedTestCode, CancellationToken.None).ConfigureAwait(false);
@@ -863,7 +880,8 @@ public TestClass(int x, int y)
                 y);
 
             // Opening parenthesis followed by space
-            var s3 = new String('a',
+            var s3 = new String(
+                'a',
                 x);
         }
     }

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs

@@ -262,7 +262,7 @@ private static void HandleOpenParenToken(SyntaxTreeAnalysisContext context, Synt
 
             if (token.IsFollowedByWhitespace())
             {
-                context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), TokenSpacingProperties.RemoveFollowing));
+                context.ReportDiagnostic(Diagnostic.Create(DescriptorNotFollowed, token.GetLocation(), TokenSpacingProperties.RemoveFollowingPreserveLayout));
             }
         }
     }

StyleCop.Analyzers/StyleCop.Analyzers/SpacingRules/TokenSpacingProperties.cs

@@ -61,5 +61,11 @@ internal static class TokenSpacingProperties
             ImmutableDictionary<string, string>.Empty
                 .SetItem(LocationKey, LocationFollowing)
                 .SetItem(ActionKey, ActionRemove);
+
+        internal static ImmutableDictionary<string, string> RemoveFollowingPreserveLayout { get; } =
+            ImmutableDictionary<string, string>.Empty
+                .SetItem(LocationKey, LocationFollowing)
+                .SetItem(ActionKey, ActionRemove)
+                .SetItem(LayoutKey, LayoutPreserve);
     }
 }