Merge pull request #2231 from vweijsters/fix-2230

Fixed crash in PropertySummaryDocumentationAnalyzer

Author: sharwell

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1623UnitTests.cs

@@ -225,6 +225,25 @@ public class TestClass
             await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Verifies that an empty tag summary is ignored (should be handled by SA1606)
+        /// This is a regression test for #2230
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        public async Task VerifyEmptySummaryTagIsIgnoredAsync()
+        {
+            var testCode = @"
+public class TestClass
+{
+    /// <summary/>
+    public int TestProperty { get; set; }
+}
+";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         /// <inheritdoc/>
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1624UnitTests.cs

@@ -185,6 +185,25 @@ public int TestProperty
             await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
         }
 
+        /// <summary>
+        /// Verifies that an empty tag summary is ignored (should be handled by SA1606)
+        /// This is a regression test for #2230
+        /// </summary>
+        /// <returns>A <see cref="Task"/> representing the asynchronous unit test.</returns>
+        [Fact]
+        public async Task VerifyEmptySummaryTagIsIgnoredAsync()
+        {
+            var testCode = @"
+public class TestClass
+{
+    /// <summary/>
+    public int TestProperty { get; set; }
+}
+";
+
+            await this.VerifyCSharpDiagnosticAsync(testCode, EmptyDiagnosticResults, CancellationToken.None).ConfigureAwait(false);
+        }
+
         /// <inheritdoc/>
         protected override CodeFixProvider GetCSharpCodeFixProvider()
         {

StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PropertySummaryDocumentationAnalyzer.cs

@@ -113,10 +113,10 @@ private static void AnalyzeSummaryElement(SyntaxNodeAnalysisContext context, Xml
                 }
             }
 
-            XmlElementSyntax summaryElement = (XmlElementSyntax)syntax;
+            XmlElementSyntax summaryElement = syntax as XmlElementSyntax;
             if (summaryElement == null)
             {
-                // This is reported by SA1604.
+                // This is reported by SA1604 or SA1606.
                 return;
             }