Skip to content

Commit f788948

Browse files
committed
Use pattern matching instead of is-cast
1 parent 9b13abb commit f788948

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1407ArithmeticExpressionsMustDeclarePrecedence.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,22 +83,18 @@ private static void HandleBinaryExpression(SyntaxNodeAnalysisContext context)
8383
{
8484
BinaryExpressionSyntax binSyntax = (BinaryExpressionSyntax)context.Node;
8585

86-
if (binSyntax.Left is BinaryExpressionSyntax)
86+
if (binSyntax.Left is BinaryExpressionSyntax left)
8787
{
8888
// Check if the operations are of the same kind
89-
var left = (BinaryExpressionSyntax)binSyntax.Left;
90-
9189
if (!IsSameFamily(binSyntax.OperatorToken, left.OperatorToken))
9290
{
9391
context.ReportDiagnostic(Diagnostic.Create(Descriptor, left.GetLocation()));
9492
}
9593
}
9694

97-
if (binSyntax.Right is BinaryExpressionSyntax)
95+
if (binSyntax.Right is BinaryExpressionSyntax right)
9896
{
9997
// Check if the operations are of the same kind
100-
var right = (BinaryExpressionSyntax)binSyntax.Right;
101-
10298
if (!IsSameFamily(binSyntax.OperatorToken, right.OperatorToken))
10399
{
104100
context.ReportDiagnostic(Diagnostic.Create(Descriptor, right.GetLocation()));

StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1408ConditionalExpressionsMustDeclarePrecedence.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,9 @@ private static void HandleBinaryExpression(SyntaxNodeAnalysisContext context)
8888
{
8989
BinaryExpressionSyntax binSyntax = (BinaryExpressionSyntax)context.Node;
9090

91-
if (binSyntax.Left is BinaryExpressionSyntax)
91+
if (binSyntax.Left is BinaryExpressionSyntax left)
9292
{
9393
// Check if the operations are of the same kind
94-
var left = (BinaryExpressionSyntax)binSyntax.Left;
9594
if (left.OperatorToken.IsKind(SyntaxKind.AmpersandAmpersandToken) || left.OperatorToken.IsKind(SyntaxKind.BarBarToken))
9695
{
9796
if (!IsSameFamily(binSyntax.OperatorToken, left.OperatorToken))
@@ -101,10 +100,9 @@ private static void HandleBinaryExpression(SyntaxNodeAnalysisContext context)
101100
}
102101
}
103102

104-
if (binSyntax.Right is BinaryExpressionSyntax)
103+
if (binSyntax.Right is BinaryExpressionSyntax right)
105104
{
106105
// Check if the operations are of the same kind
107-
var right = (BinaryExpressionSyntax)binSyntax.Right;
108106
if (right.OperatorToken.IsKind(SyntaxKind.AmpersandAmpersandToken) || right.OperatorToken.IsKind(SyntaxKind.BarBarToken))
109107
{
110108
if (!IsSameFamily(binSyntax.OperatorToken, right.OperatorToken))

0 commit comments

Comments
 (0)