Fix IDE0059 Value assigned is never used (includes a bugfix)

vweijsters · vweijsters · commit fb9a35176a50 · 2019-04-29T22:34:37.000+02:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1626CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1626CodeFixProvider.cs
@@ -53,7 +53,6 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
 
         private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)
         {
-            var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
             var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);
 
             TextChange textChange = new TextChange(new TextSpan(diagnostic.Location.SourceSpan.Start, 1), string.Empty);
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1642SA1643CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1642SA1643CodeFixProvider.cs
@@ -174,8 +174,6 @@ private static Task<Document> GetTransformedDocumentAsync(Document document, Syn
         private static Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode root, XmlEmptyElementSyntax node)
         {
             var typeDeclaration = node.FirstAncestorOrSelf<BaseTypeDeclarationSyntax>();
-            var declarationSyntax = node.FirstAncestorOrSelf<BaseMethodDeclarationSyntax>();
-            bool isStruct = typeDeclaration.IsKind(SyntaxKind.StructDeclaration);
 
             TypeParameterListSyntax typeParameterList;
             if (typeDeclaration is ClassDeclarationSyntax classDeclaration)
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Helpers/FormattingHelper.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/Helpers/FormattingHelper.cs
@@ -92,7 +92,7 @@ public static SyntaxTrivia WithoutFormatting(this SyntaxTrivia trivia)
                 }
             }
 
-            return WithoutFormattingImpl(trivia);
+            return WithoutFormattingImpl(result);
         }
 
         /// <summary>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1129CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1129CodeFixProvider.cs
@@ -65,8 +65,7 @@ private static SyntaxNode GetReplacementNode(SyntaxNode node, SemanticModel sema
             var symbolInfo = semanticModel.GetSymbolInfo(newExpression.Type, cancellationToken);
             var namedTypeSymbol = symbolInfo.Symbol as INamedTypeSymbol;
 
-            SyntaxNode replacement = null;
-            string memberName = null;
+            SyntaxNode replacement;
 
             if (IsType<CancellationToken>(namedTypeSymbol))
             {
@@ -79,7 +78,7 @@ private static SyntaxNode GetReplacementNode(SyntaxNode node, SemanticModel sema
                     replacement = ConstructMemberAccessSyntax(newExpression.Type, nameof(CancellationToken.None));
                 }
             }
-            else if (IsEnumWithDefaultMember(namedTypeSymbol, out memberName))
+            else if (IsEnumWithDefaultMember(namedTypeSymbol, out string memberName))
             {
                 replacement = ConstructMemberAccessSyntax(newExpression.Type, memberName);
             }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/IndentationHelperTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/IndentationHelperTests.cs
@@ -179,7 +179,7 @@ private static Document CreateTestDocument(string source, int indentationSize =
   }}
 }}
 ";
-                var settingsDocumentId = DocumentId.CreateNewId(projectId);
+
                 solution = solution.AddAdditionalDocument(documentId, SettingsHelper.SettingsFileName, settings);
             }
 
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PartialElementDocumentationSummaryBase.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/PartialElementDocumentationSummaryBase.cs
@@ -168,8 +168,6 @@ private string ExpandDocumentation(Compilation compilation, DocumentationComment
 
             sb.AppendLine("<member>");
 
-            var documentationChildren = new List<XElement>();
-
             foreach (XmlNodeSyntax xmlNode in documentCommentTrivia.Content)
             {
                 if (xmlNode == includeTag)
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1643DestructorSummaryDocumentationMustBeginWithStandardText.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1643DestructorSummaryDocumentationMustBeginWithStandardText.cs
@@ -78,7 +78,6 @@ public override void Initialize(AnalysisContext context)
 
         private static void HandleDestructor(SyntaxNodeAnalysisContext context)
         {
-            var destructorDeclaration = (DestructorDeclarationSyntax)context.Node;
             var settings = context.Options.GetStyleCopSettings(context.CancellationToken);
             var culture = new CultureInfo(settings.DocumentationRules.DocumentationCulture);
             var resourceManager = DocumentationResources.ResourceManager;
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlCommentHelper.cs b/StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlCommentHelper.cs
@@ -122,18 +122,13 @@ internal static bool IsConsideredEmpty(XmlNodeSyntax xmlSyntax, bool considerEmp
                 return true;
             }
 
-            if (xmlSyntax is XmlEmptyElementSyntax emptyElement)
+            if (xmlSyntax is XmlEmptyElementSyntax)
             {
                 // This includes <inheritdoc/>
                 return considerEmptyElements;
             }
 
-            if (xmlSyntax is XmlProcessingInstructionSyntax processingElement)
-            {
-                return false;
-            }
-
-            return true;
+            return !(xmlSyntax is XmlProcessingInstructionSyntax);
         }
 
         /// <summary>
@@ -162,12 +157,7 @@ internal static bool IsConsideredEmpty(XNode node)
                 return true;
             }
 
-            if (node is XProcessingInstruction processingElement)
-            {
-                return false;
-            }
-
-            return true;
+            return !(node is XProcessingInstruction);
         }
 
         /// <summary>
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1516ElementsMustBeSeparatedByBlankLine.cs b/StyleCop.Analyzers/StyleCop.Analyzers/LayoutRules/SA1516ElementsMustBeSeparatedByBlankLine.cs
@@ -204,8 +204,6 @@ private static void HandleCompilationUnit(SyntaxNodeAnalysisContext context, Sty
                 {
                     ReportIfThereIsNoBlankLine(context, previousItem, members[0]);
                 }
-
-                previousItem = members.Last();
             }
         }
 
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1119StatementMustNotUseUnnecessaryParenthesis.cs b/StyleCop.Analyzers/StyleCop.Analyzers/MaintainabilityRules/SA1119StatementMustNotUseUnnecessaryParenthesis.cs
@@ -161,7 +161,7 @@ private static void HandleParenthesizedExpression(SyntaxNodeAnalysisContext cont
                         }
                         else
                         {
-                            if (node.Parent is AssignmentExpressionSyntax assignValue)
+                            if (node.Parent is AssignmentExpressionSyntax)
                             {
                                 ReportDiagnostic(context, node);
                             }
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1202ElementsMustBeOrderedByAccess.cs b/StyleCop.Analyzers/StyleCop.Analyzers/OrderingRules/SA1202ElementsMustBeOrderedByAccess.cs
@@ -131,7 +131,6 @@ private static void HandleTypeDeclaration(SyntaxNodeAnalysisContext context, Sty
 
         private static void HandleMemberList(SyntaxNodeAnalysisContext context, ImmutableArray<OrderingTrait> elementOrder, int accessibilityIndex, SyntaxList<MemberDeclarationSyntax> members, AccessLevel defaultAccessLevel)
         {
-            MemberDeclarationSyntax previousMember = null;
             var previousSyntaxKind = SyntaxKind.None;
             var previousAccessLevel = AccessLevel.NotSpecified;
             bool previousIsConst = false;
@@ -212,7 +211,6 @@ private static void HandleMemberList(SyntaxNodeAnalysisContext context, Immutabl
                     }
                 }
 
-                previousMember = member;
                 previousSyntaxKind = currentSyntaxKind;
                 previousAccessLevel = currentAccessLevel;
                 previousIsConst = currentIsConst;
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1120CommentsMustContainText.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1120CommentsMustContainText.cs
@@ -82,10 +82,8 @@ private static void HandleMultiLineComment(SyntaxTreeAnalysisContext context, Sy
 
         private static void HandleSingleLineComment(SyntaxTreeAnalysisContext context, SyntaxTrivia singleLineComment)
         {
-            int index = 0;
-
             // PERF: Explicitly cast to IReadOnlyList so we only box once.
-            IReadOnlyList<SyntaxTrivia> list = TriviaHelper.GetContainingTriviaList(singleLineComment, out index);
+            IReadOnlyList<SyntaxTrivia> list = TriviaHelper.GetContainingTriviaList(singleLineComment, out int index);
             var firstNonWhiteSpace = TriviaHelper.IndexOfFirstNonWhitespaceTrivia(list);
 
             // When we encounter a block of single line comments, we only want to raise this diagnostic
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1122UseStringEmptyForEmptyStrings.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1122UseStringEmptyForEmptyStrings.cs
@@ -88,7 +88,7 @@ private static bool HasToBeConstant(LiteralExpressionSyntax literalExpression)
 
             if (outermostExpression.Parent is EqualsValueClauseSyntax equalsValueClause)
             {
-                if (equalsValueClause.Parent is ParameterSyntax parameterSyntax)
+                if (equalsValueClause.Parent is ParameterSyntax)
                 {
                     return true;
                 }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,6 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)`
`53`	`53`
`54`	`54`	`private static async Task<Document> GetTransformedDocumentAsync(Document document, Diagnostic diagnostic, CancellationToken cancellationToken)`
`55`	`55`	`{`
`56`		`- var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);`
`57`	`56`	`var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false);`
`58`	`57`
`59`	`58`	`TextChange textChange = new TextChange(new TextSpan(diagnostic.Location.SourceSpan.Start, 1), string.Empty);`
Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,6 @@ private static Task<Document> GetTransformedDocumentAsync(Document document, Syn`
`174`	`174`	`private static Task<Document> GetTransformedDocumentAsync(Document document, SyntaxNode root, XmlEmptyElementSyntax node)`
`175`	`175`	`{`
`176`	`176`	`var typeDeclaration = node.FirstAncestorOrSelf<BaseTypeDeclarationSyntax>();`
`177`		`- var declarationSyntax = node.FirstAncestorOrSelf<BaseMethodDeclarationSyntax>();`
`178`		`- bool isStruct = typeDeclaration.IsKind(SyntaxKind.StructDeclaration);`
`179`	`177`
`180`	`178`	`TypeParameterListSyntax typeParameterList;`
`181`	`179`	`if (typeDeclaration is ClassDeclarationSyntax classDeclaration)`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public static SyntaxTrivia WithoutFormatting(this SyntaxTrivia trivia)`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`- return WithoutFormattingImpl(trivia);`
	`95`	`+ return WithoutFormattingImpl(result);`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,7 @@ private static SyntaxNode GetReplacementNode(SyntaxNode node, SemanticModel sema`
`65`	`65`	`var symbolInfo = semanticModel.GetSymbolInfo(newExpression.Type, cancellationToken);`
`66`	`66`	`var namedTypeSymbol = symbolInfo.Symbol as INamedTypeSymbol;`
`67`	`67`
`68`		`- SyntaxNode replacement = null;`
`69`		`- string memberName = null;`
	`68`	`+ SyntaxNode replacement;`
`70`	`69`
`71`	`70`	`if (IsType<CancellationToken>(namedTypeSymbol))`
`72`	`71`	`{`
`@@ -79,7 +78,7 @@ private static SyntaxNode GetReplacementNode(SyntaxNode node, SemanticModel sema`
`79`	`78`	`replacement = ConstructMemberAccessSyntax(newExpression.Type, nameof(CancellationToken.None));`
`80`	`79`	`}`
`81`	`80`	`}`
`82`		`- else if (IsEnumWithDefaultMember(namedTypeSymbol, out memberName))`
	`81`	`+ else if (IsEnumWithDefaultMember(namedTypeSymbol, out string memberName))`
`83`	`82`	`{`
`84`	`83`	`replacement = ConstructMemberAccessSyntax(newExpression.Type, memberName);`
`85`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ private static Document CreateTestDocument(string source, int indentationSize =`
`179`	`179`	`}}`
`180`	`180`	`}}`
`181`	`181`	`";`
`182`		`- var settingsDocumentId = DocumentId.CreateNewId(projectId);`
	`182`	`+`
`183`	`183`	`solution = solution.AddAdditionalDocument(documentId, SettingsHelper.SettingsFileName, settings);`
`184`	`184`	`}`
`185`	`185`
Original file line number	Diff line number	Diff line change
`@@ -168,8 +168,6 @@ private string ExpandDocumentation(Compilation compilation, DocumentationComment`
`168`	`168`
`169`	`169`	`sb.AppendLine("<member>");`
`170`	`170`
`171`		`- var documentationChildren = new List<XElement>();`
`172`		`-`
`173`	`171`	`foreach (XmlNodeSyntax xmlNode in documentCommentTrivia.Content)`
`174`	`172`	`{`
`175`	`173`	`if (xmlNode == includeTag)`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ public override void Initialize(AnalysisContext context)`
`78`	`78`
`79`	`79`	`private static void HandleDestructor(SyntaxNodeAnalysisContext context)`
`80`	`80`	`{`
`81`		`- var destructorDeclaration = (DestructorDeclarationSyntax)context.Node;`
`82`	`81`	`var settings = context.Options.GetStyleCopSettings(context.CancellationToken);`
`83`	`82`	`var culture = new CultureInfo(settings.DocumentationRules.DocumentationCulture);`
`84`	`83`	`var resourceManager = DocumentationResources.ResourceManager;`
Original file line number	Diff line number	Diff line change
`@@ -122,18 +122,13 @@ internal static bool IsConsideredEmpty(XmlNodeSyntax xmlSyntax, bool considerEmp`
`122`	`122`	`return true;`
`123`	`123`	`}`
`124`	`124`
`125`		`- if (xmlSyntax is XmlEmptyElementSyntax emptyElement)`
	`125`	`+ if (xmlSyntax is XmlEmptyElementSyntax)`
`126`	`126`	`{`
`127`	`127`	`// This includes <inheritdoc/>`
`128`	`128`	`return considerEmptyElements;`
`129`	`129`	`}`
`130`	`130`
`131`		`- if (xmlSyntax is XmlProcessingInstructionSyntax processingElement)`
`132`		`- {`
`133`		`- return false;`
`134`		`- }`
`135`		`-`
`136`		`- return true;`
	`131`	`+ return !(xmlSyntax is XmlProcessingInstructionSyntax);`
`137`	`132`	`}`
`138`	`133`
`139`	`134`	`/// <summary>`
`@@ -162,12 +157,7 @@ internal static bool IsConsideredEmpty(XNode node)`
`162`	`157`	`return true;`
`163`	`158`	`}`
`164`	`159`
`165`		`- if (node is XProcessingInstruction processingElement)`
`166`		`- {`
`167`		`- return false;`
`168`		`- }`
`169`		`-`
`170`		`- return true;`
	`160`	`+ return !(node is XProcessingInstruction);`
`171`	`161`	`}`
`172`	`162`
`173`	`163`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -204,8 +204,6 @@ private static void HandleCompilationUnit(SyntaxNodeAnalysisContext context, Sty`
`204`	`204`	`{`
`205`	`205`	`ReportIfThereIsNoBlankLine(context, previousItem, members[0]);`
`206`	`206`	`}`
`207`		`-`
`208`		`- previousItem = members.Last();`
`209`	`207`	`}`
`210`	`208`	`}`
`211`	`209`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ private static void HandleParenthesizedExpression(SyntaxNodeAnalysisContext cont`
`161`	`161`	`}`
`162`	`162`	`else`
`163`	`163`	`{`
`164`		`- if (node.Parent is AssignmentExpressionSyntax assignValue)`
	`164`	`+ if (node.Parent is AssignmentExpressionSyntax)`
`165`	`165`	`{`
`166`	`166`	`ReportDiagnostic(context, node);`
`167`	`167`	`}`