Fix all violations of SA1129 (DoNotUseDefaultValueTypeConstructor)

sharwell · sharwell · commit fbabf70ebec0 · 2015-09-26T19:12:12.000-05:00
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642SA1643CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers/DocumentationRules/SA1642SA1643CodeFixProvider.cs
@@ -265,7 +265,7 @@ private static XmlEmptyElementSyntax BuildSeeElement(SyntaxToken identifier, Typ
 
         private static TypeArgumentListSyntax ParameterToArgumentListSyntax(TypeParameterListSyntax typeParameters)
         {
-            var list = new SeparatedSyntaxList<TypeSyntax>();
+            var list = SyntaxFactory.SeparatedList<TypeSyntax>();
             list = list.AddRange(typeParameters.Parameters.Select(p => SyntaxFactory.ParseName(p.ToString()).WithTriviaFrom(p)));
 
             for (int i = 0; i < list.SeparatorCount; i++)
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1120CodeFixProvider.cs b/StyleCop.Analyzers/StyleCop.Analyzers/ReadabilityRules/SA1120CodeFixProvider.cs
@@ -79,7 +79,7 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen
             // Replace all roots with an empty node
             var newRoot = root.ReplaceTrivia(triviaToRemove, (original, rewritten) =>
             {
-                return new SyntaxTrivia();
+                return default(SyntaxTrivia);
             });
 
             Document updatedDocument = document.WithSyntaxRoot(newRoot);

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ private static XmlEmptyElementSyntax BuildSeeElement(SyntaxToken identifier, Typ`
`265`	`265`
`266`	`266`	`private static TypeArgumentListSyntax ParameterToArgumentListSyntax(TypeParameterListSyntax typeParameters)`
`267`	`267`	`{`
`268`		`- var list = new SeparatedSyntaxList<TypeSyntax>();`
	`268`	`+ var list = SyntaxFactory.SeparatedList<TypeSyntax>();`
`269`	`269`	`list = list.AddRange(typeParameters.Parameters.Select(p => SyntaxFactory.ParseName(p.ToString()).WithTriviaFrom(p)));`
`270`	`270`
`271`	`271`	`for (int i = 0; i < list.SeparatorCount; i++)`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ private static async Task<Document> GetTransformedDocumentAsync(Document documen`
`79`	`79`	`// Replace all roots with an empty node`
`80`	`80`	`var newRoot = root.ReplaceTrivia(triviaToRemove, (original, rewritten) =>`
`81`	`81`	`{`
`82`		`- return new SyntaxTrivia();`
	`82`	`+ return default(SyntaxTrivia);`
`83`	`83`	`});`
`84`	`84`
`85`	`85`	`Document updatedDocument = document.WithSyntaxRoot(newRoot);`