Add blank line filtering to XmlSyntaxFactory.MultiLineElement

Author: vweijsters

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1600UnitTests.cs

@@ -726,7 +726,7 @@ public Task<T> TestMethod6<T>(T param1, int param2)
 public {typeKeyword} Test
 {{
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <returns>A <see cref=""Task""/> representing the result of the asynchronous operation.</returns>
     public Task TestMethod1()
@@ -735,7 +735,7 @@ public Task TestMethod1()
     }}
 
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <returns>A <see cref=""Task{{TResult}}""/> representing the result of the asynchronous operation.</returns>
     public Task<int> TestMethod2()
@@ -744,7 +744,7 @@ public Task<int> TestMethod2()
     }}
 
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <typeparam name=""T""></typeparam>
     /// <returns>A <see cref=""Task{{TResult}}""/> representing the result of the asynchronous operation.</returns>
@@ -754,7 +754,7 @@ public Task<T> TestMethod3<T>()
     }}
 
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <param name=""param1""></param>
     /// <param name=""param2""></param>
@@ -765,7 +765,7 @@ public Task TestMethod4(int param1, int param2)
     }}
 
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <param name=""param1""></param>
     /// <param name=""param2""></param>
@@ -776,7 +776,7 @@ public Task<int> TestMethod5(int param1, int param2)
     }}
 
     /// <summary>
-    /// 
+    ///
     /// </summary>
     /// <typeparam name=""T""></typeparam>
     /// <param name=""param1""></param>

StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1609UnitTests.cs

@@ -270,7 +270,7 @@ public class ClassName
     /// <summary>
     /// </summary>
     /// <value>
-    /// 
+    ///
     /// </value>
     public int Property
     {

StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/XmlSyntaxFactoryTests.cs

@@ -57,7 +57,7 @@ public void TestSummaryElement()
             Assert.Equal(expected, XmlSyntaxFactory.SummaryElement("\r\n", XmlSyntaxFactory.Text("Summary.")).ToFullString());
         }
 
-        [Fact(Skip = "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2672")]
+        [Fact]
         [WorkItem(2672, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/2672")]
         public void TestEmptySummaryElement()
         {

StyleCop.Analyzers/StyleCop.Analyzers/Helpers/XmlSyntaxFactory.cs

@@ -25,9 +25,28 @@ public static XmlElementSyntax MultiLineElement(string localName, string newLine
 
         public static XmlElementSyntax MultiLineElement(XmlNameSyntax name, string newLineText, SyntaxList<XmlNodeSyntax> content)
         {
+            var newContent = content.Insert(0, NewLine(newLineText)).Add(NewLine(newLineText));
+
+            for (var i = 1; i < newContent.Count; i++)
+            {
+                if (newContent[i] is XmlTextSyntax xmlTextSyntax
+                    && xmlTextSyntax.TextTokens[0].ValueText == newLineText)
+                {
+                    var previousTrailingTrivia = newContent[i - 1].GetTrailingTrivia();
+                    if (previousTrailingTrivia.Count > 0)
+                    {
+                        var lastTrivia = previousTrailingTrivia.Last();
+                        var updatedLastTriviaText = lastTrivia.ToString().TrimEnd(' ', '\t');
+
+                        var updatedTrailingTrivia = previousTrailingTrivia.Replace(lastTrivia, SyntaxFactory.SyntaxTrivia(lastTrivia.Kind(), updatedLastTriviaText));
+                        newContent = newContent.Replace(newContent[i - 1], newContent[i - 1].WithTrailingTrivia(updatedTrailingTrivia));
+                    }
+                }
+            }
+
             return SyntaxFactory.XmlElement(
                 SyntaxFactory.XmlElementStartTag(name),
-                content.Insert(0, NewLine(newLineText)).Add(NewLine(newLineText)),
+                newContent,
                 SyntaxFactory.XmlElementEndTag(name));
         }