DeclaredAccessibility

Author: JohanLarsson

WpfAnalyzers/Helpers/BackingFieldOrProperty.cs

@@ -1,5 +1,6 @@
 namespace WpfAnalyzers;
 
+using System;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
@@ -27,6 +28,13 @@ private BackingFieldOrProperty(FieldOrProperty fieldOrProperty)
 
     internal INamedTypeSymbol ContainingType => this.FieldOrProperty.ContainingType;
 
+    internal Accessibility DeclaredAccessibility => this.FieldOrProperty.Symbol switch
+    {
+        IFieldSymbol field => field.DeclaredAccessibility,
+        IPropertySymbol property => property.DeclaredAccessibility,
+        _ => throw new NotSupportedException("Neither field nor property."),
+    };
+
     internal string Name => this.FieldOrProperty.Name;
 
     internal static BackingFieldOrProperty? Match(ISymbol? symbol)
@@ -167,7 +175,7 @@ IPropertySymbol property
         if (this.Value(cancellationToken) is { } value &&
             value is InvocationExpressionSyntax { Expression: MemberAccessExpressionSyntax { Expression: { } addOwner } } invocation &&
             semanticModel.TryGetSymbol(invocation, KnownSymbols.DependencyProperty.AddOwner, cancellationToken, out _) &&
-            semanticModel.TryGetSymbol(addOwner,   cancellationToken,                        out var addOwnerSymbol))
+            semanticModel.TryGetSymbol(addOwner, cancellationToken, out var addOwnerSymbol))
         {
             return Match(addOwnerSymbol);
         }

WpfAnalyzers/WPF0041SetMutableUsingSetCurrentValue.cs

@@ -32,7 +32,7 @@ private static void HandleAssignment(SyntaxNodeAnalysisContext context)
             !IsInConstructor(assignment) &&
             context.SemanticModel.TryGetSymbol(left, context.CancellationToken, out IPropertySymbol? property) &&
             !IsIgnored(property) &&
-            ClrProperty.Match(property, context.SemanticModel, context.CancellationToken) is { BackingSet: { } backingSet } &&
+            ClrProperty.Match(property, context.SemanticModel, context.CancellationToken) is { BackingSet: { DeclaredAccessibility: not Accessibility.Private } backingSet } &&
             backingSet.FieldOrProperty.Type == KnownSymbols.DependencyProperty &&
             !IsAssignedCreatedInScope(left, context.SemanticModel, context.CancellationToken))
         {