fix warnings

Author: JohanLarsson

WpfAnalyzers/Analyzers/PropertyMetadataAnalyzer.cs

@@ -31,8 +31,7 @@ public override void Initialize(AnalysisContext context)
     private static void Handle(SyntaxNodeAnalysisContext context)
     {
         if (!context.IsExcludedFromAnalysis() &&
-            context.Node is ObjectCreationExpressionSyntax objectCreation &&
-            context.ContainingSymbol is { IsStatic: true } &&
+            context is { Node: ObjectCreationExpressionSyntax objectCreation, ContainingSymbol.IsStatic: true } &&
             PropertyMetadata.Match(objectCreation, context.SemanticModel, context.CancellationToken) is { } propertyMetadata)
         {
             if (propertyMetadata.FindRegisteredName(context.SemanticModel, context.CancellationToken) is { Value: { } registeredName })

WpfAnalyzers/Analyzers/RegistrationAnalyzer.cs

@@ -30,8 +30,7 @@ public override void Initialize(AnalysisContext context)
     private static void Handle(SyntaxNodeAnalysisContext context)
     {
         if (!context.IsExcludedFromAnalysis() &&
-            context.Node is InvocationExpressionSyntax invocation &&
-            context.ContainingSymbol is { IsStatic: true } &&
+            context is { Node: InvocationExpressionSyntax invocation, ContainingSymbol.IsStatic: true } &&
             DependencyProperty.Register.MatchAny(invocation, context.SemanticModel, context.CancellationToken) is { NameArgument: { } nameArgument } register &&
             register.PropertyName(context.SemanticModel, context.CancellationToken) is { } registeredName)
         {

WpfAnalyzers/Analyzers/RoutedEventBackingFieldOrPropertyAnalyzer.cs

@@ -30,8 +30,7 @@ public override void Initialize(AnalysisContext context)
     private static void Handle(SyntaxNodeAnalysisContext context)
     {
         if (!context.IsExcludedFromAnalysis() &&
-            context.Node is MemberDeclarationSyntax memberDeclaration &&
-            context.ContainingSymbol is { } &&
+            context is { Node: MemberDeclarationSyntax memberDeclaration, ContainingSymbol: not null } &&
             FieldOrProperty.TryCreate(context.ContainingSymbol, out var backing) &&
             backing.Type == KnownSymbols.RoutedEvent &&
             backing.Value(context.CancellationToken) is InvocationExpressionSyntax invocation &&

WpfAnalyzers/Analyzers/RoutedEventEventDeclarationAnalyzer.cs

@@ -28,8 +28,7 @@ public override void Initialize(AnalysisContext context)
     private static void Handle(SyntaxNodeAnalysisContext context)
     {
         if (!context.IsExcludedFromAnalysis() &&
-            context.ContainingSymbol is IEventSymbol eventSymbol &&
-            context.Node is EventDeclarationSyntax eventDeclaration &&
+            context is { ContainingSymbol: IEventSymbol eventSymbol, Node: EventDeclarationSyntax eventDeclaration } &&
             EventDeclarationWalker.TryGetCalls(eventDeclaration, out var addCall, out var removeCall))
         {
             if (addCall.TryGetMethodName(out var addName) &&
@@ -65,8 +64,7 @@ addArg.Expression is IdentifierNameSyntax addIdentifier &&
                             removeIdentifier.Identifier.ValueText));
                 }
                 else if (eventDeclaration.Parent is TypeDeclarationSyntax typeDeclaration &&
-                         BackingFieldWalker.TryGetRegistration(typeDeclaration, addIdentifier.Identifier.ValueText, out var registration) &&
-                         registration.ArgumentList is { })
+                         BackingFieldWalker.TryGetRegistration(typeDeclaration, addIdentifier.Identifier.ValueText, out var registration))
                 {
                     if (registration.TryGetArgumentAtIndex(0, out var nameARg) &&
                         nameARg.TryGetStringValue(context.SemanticModel, context.CancellationToken, out var registeredName) &&

WpfAnalyzers/CodeFixes/AttachedPropertyBrowsableForTypeAttributeFix.cs

@@ -31,7 +31,8 @@ protected override async Task RegisterCodeFixesAsync(DocumentEditorCodeFixContex
             if (syntaxRoot is { } &&
                 syntaxRoot.TryFindNodeOrAncestor(diagnostic, out MethodDeclarationSyntax? methodDeclaration) &&
                 methodDeclaration.ParameterList is { } parameterList &&
-                parameterList.Parameters.TrySingle(out var parameter))
+                parameterList.Parameters.TrySingle(out var parameter) &&
+                parameter.Type is { })
             {
                 context.RegisterCodeFix(
                     $"Add [AttachedPropertyBrowsableForType(typeof({parameter.Type}))].",

WpfAnalyzers/CodeFixes/UseNameofFix.cs

@@ -49,7 +49,7 @@ async Task FixAsync(DocumentEditor editor, CancellationToken cancellationToken)
 
                     if (!expression!.IsInStaticContext() &&
                         editor.SemanticModel.LookupSymbols(expression!.SpanStart, name: name).TrySingle(out var member) &&
-                        (member is IFieldSymbol || member is IPropertySymbol || member is IMethodSymbol) &&
+                        member is IFieldSymbol or IPropertySymbol or IMethodSymbol &&
                         !member.IsStatic &&
                         await Qualify(member).ConfigureAwait(false) != CodeStyleResult.No)
                     {

WpfAnalyzers/WPF0011ContainingTypeShouldBeRegisteredOwner.cs

@@ -25,8 +25,7 @@ public override void Initialize(AnalysisContext context)
     private static void Handle(SyntaxNodeAnalysisContext context)
     {
         if (!context.IsExcludedFromAnalysis() &&
-            context.Node is InvocationExpressionSyntax invocation &&
-            context.ContainingSymbol is { IsStatic: true })
+            context is { Node: InvocationExpressionSyntax invocation, ContainingSymbol.IsStatic: true })
         {
             if (DependencyProperty.Register.MatchAny(invocation, context.SemanticModel, context.CancellationToken) is { OwnerTypeArgument: { } ownerTypeArgument })
             {